# Cppcheck report - LibreOffice: chart2/source/controller/main/ChartController_EditData.cxx

     1
     2
     3
     4
     5
     6
     7
     8
     9
    10
    11
    12
    13
    14
    15
    16
    17
    18
    19
    20
    21
    22
    23
    24
    25
    26
    27
    28
    29
    30
    31
    32
    33
    34
    35
    36
    37
    38
    39
    40
    41
    42
    43
    44
    45
    46
    47
    48
    49
    50
    51
    52
    53
    54
    55
    56
    57
    58
    59
    60
    61
    62
    63
    64
    65
    66
    67
    68
    69

    /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
    /*
     * This file is part of the LibreOffice project.
     *
     * This Source Code Form is subject to the terms of the Mozilla Public
     * License, v. 2.0. If a copy of the MPL was not distributed with this
     * file, You can obtain one at http://mozilla.org/MPL/2.0/.
     *
     * This file incorporates work covered by the following license notice:
     *
     *   Licensed to the Apache Software Foundation (ASF) under one or more
     *   contributor license agreements. See the NOTICE file distributed
     *   with this work for additional information regarding copyright
     *   ownership. The ASF licenses this file to you under the Apache
     *   License, Version 2.0 (the "License"); you may not use this file
     *   except in compliance with the License. You may obtain a copy of
     *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
     */

    #include "ChartController.hxx"
    #include "macros.hxx"

    #include "dlg_DataEditor.hxx"
    #include "DataSourceHelper.hxx"
    #include "DiagramHelper.hxx"
    #include "ControllerLockGuard.hxx"
    #include "UndoGuard.hxx"
    #include "ResId.hxx"
    #include "Strings.hrc"

    #include <vcl/msgbox.hxx>
    #include <vcl/svapp.hxx>
    #include <osl/mutex.hxx>
    #include <com/sun/star/chart2/XChartDocument.hpp>

    using namespace ::com::sun::star;

    using ::com::sun::star::uno::Reference;
    using ::com::sun::star::uno::Sequence;

    namespace chart
    {

    void ChartController::executeDispatch_EditData()
    {
        Reference< chart2::XChartDocument > xChartDoc( getModel(), uno::UNO_QUERY );
        if( xChartDoc.is())
        {
            vcl::Window* pParent( NULL );<--- The scope of the variable 'pParent' can be reduced.

            Reference< ::com::sun::star::chart2::data::XDataProvider > xDataProvider( xChartDoc->getDataProvider());

            {
                SolarMutexGuard aSolarGuard;
                // using assignment for broken gcc 3.3
                UndoLiveUpdateGuardWithData aUndoGuard = UndoLiveUpdateGuardWithData(
                    SCH_RESSTR( STR_ACTION_EDIT_CHART_DATA ),
                    m_xUndoManager );
                DataEditor aDataEditorDialog( pParent, xChartDoc, m_xCC );
                if (aDataEditorDialog.Execute() == RET_OK)
                    aDataEditorDialog.ApplyChangesToModel();
                aUndoGuard.commit();
            }
        }
    }

    } //  namespace chart

    /* vim:set shiftwidth=4 softtabstop=4 expandtab: */