# Cppcheck report - LibreOffice: compilerplugins/clang/store/derivedclass.cxx

     1
     2
     3
     4
     5
     6
     7
     8
     9
    10
    11
    12
    13
    14
    15
    16
    17
    18
    19
    20
    21
    22
    23
    24
    25
    26
    27
    28
    29
    30
    31
    32
    33
    34
    35
    36
    37
    38
    39
    40
    41
    42
    43
    44
    45
    46
    47
    48
    49
    50
    51
    52
    53
    54
    55
    56
    57
    58
    59
    60
    61
    62
    63
    64
    65
    66
    67
    68
    69
    70
    71

    /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
    /*
     * This file is part of the LibreOffice project.
     *
     * This Source Code Form is subject to the terms of the Mozilla Public
     * License, v. 2.0. If a copy of the MPL was not distributed with this
     * file, You can obtain one at http://mozilla.org/MPL/2.0/.
     */

    #include "plugin.hxx"

    namespace {

    class DerivedClass:
        public RecursiveASTVisitor<DerivedClass>,
        public loplugin::Plugin
    {
    public:
        explicit DerivedClass(InstantiationData const & data):
            Plugin(data) {}

        virtual void run() override
        { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }

        bool VisitCXXRecordDecl(CXXRecordDecl const * decl);
    };

    bool BaseCheck(const CXXRecordDecl *BaseDefinition, void *BaseClassName) {
        // print warning about deriving from this classes
        // the name has to contain namespace, e.g. foo::bar::ClassName
        const char *BaseClasses[] = {
            "Dialog",
            "ProgressBar",
            "SfxToolBoxControl",
            "StatusBar",
            0,
        };
        for (int i = 0; BaseClasses[i]; i++)
            if (BaseDefinition->getQualifiedNameAsString().compare(BaseClasses[i]) == 0) {
                *(const char **)BaseClassName = BaseClasses[i];
                return false;
            }
        return true;
    }

    bool DerivedClass::VisitCXXRecordDecl(CXXRecordDecl const * decl) {<--- The function 'VisitCXXRecordDecl' is never used.
        const char *BaseClassName = 0;
        // checking for decl->hasDefinition() avoids crash in decl->forallBases
        if (decl->hasDefinition() &&
                // not sure what hasAnyDependentBases() does,
                // but it avoids classes we don't want, e.g. WeakAggComponentImplHelper1
                !decl->hasAnyDependentBases() &&
                !decl->forallBases(BaseCheck, &BaseClassName)) {
            string warning_msg("class %0 derives from ");
            // no idea how BaseClassName can be 0 sometimes..
            if (BaseClassName)
                warning_msg += BaseClassName;
            report(
                DiagnosticsEngine::Warning,
                warning_msg,
                decl->getLocStart())
            << decl->getQualifiedNameAsString() << decl->getSourceRange();
        }
        return true;
    }

    loplugin::Plugin::Registration<DerivedClass> X("derivedclass");

    }

    /* vim:set shiftwidth=4 softtabstop=4 tabstop=4 expandtab: */