1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175 | /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <svl/cjkoptions.hxx>
#include <svl/eitem.hxx>
#include <svl/intitem.hxx>
#include <svx/dialogs.hrc>
#include <svx/svxids.hrc>
#include <svx/flagsdef.hxx>
#include <paragr.hxx>
#include <sdattr.hrc>
namespace {
class SdParagraphNumTabPage : public SfxTabPage
{
public:
SdParagraphNumTabPage(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rSet);
static std::unique_ptr<SfxTabPage> Create( weld::Container* pPage, weld::DialogController* pController, const SfxItemSet* rSet );
static const sal_uInt16* GetRanges();
virtual bool FillItemSet( SfxItemSet* rSet ) override;
virtual void Reset( const SfxItemSet* rSet ) override;
private:
bool mbModified;
std::unique_ptr<weld::CheckButton> m_xNewStartCB;
std::unique_ptr<weld::CheckButton> m_xNewStartNumberCB;
std::unique_ptr<weld::SpinButton> m_xNewStartNF;
DECL_LINK( ImplNewStartHdl, weld::Button&, void );
};
}
SdParagraphNumTabPage::SdParagraphNumTabPage(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rAttr)
: SfxTabPage(pPage, pController, "modules/sdraw/ui/paranumberingtab.ui", "DrawParaNumbering", &rAttr)
, mbModified(false)
, m_xNewStartCB(m_xBuilder->weld_check_button("checkbuttonCB_NEW_START"))
, m_xNewStartNumberCB(m_xBuilder->weld_check_button("checkbuttonCB_NUMBER_NEW_START"))
, m_xNewStartNF(m_xBuilder->weld_spin_button("spinbuttonNF_NEW_START"))
{
m_xNewStartCB->connect_clicked(LINK(this, SdParagraphNumTabPage, ImplNewStartHdl));
m_xNewStartNumberCB->connect_clicked(LINK(this, SdParagraphNumTabPage, ImplNewStartHdl));
}
std::unique_ptr<SfxTabPage> SdParagraphNumTabPage::Create(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet * rAttrSet)
{
return std::make_unique<SdParagraphNumTabPage>(pPage, pController, *rAttrSet);
}
const sal_uInt16* SdParagraphNumTabPage::GetRanges()
{
static const sal_uInt16 aRange[] =
{
ATTR_PARANUMBERING_START, ATTR_PARANUMBERING_END,
0
};
return aRange;
}
bool SdParagraphNumTabPage::FillItemSet( SfxItemSet* rSet )
{
if (m_xNewStartCB->get_state_changed_from_saved() ||
m_xNewStartNumberCB->get_state_changed_from_saved()||
m_xNewStartNF->get_value_changed_from_saved())
{
mbModified = true;
bool bNewStartChecked = TRISTATE_TRUE == m_xNewStartCB->get_state();
bool bNumberNewStartChecked = TRISTATE_TRUE == m_xNewStartNumberCB->get_state();
rSet->Put(SfxBoolItem(ATTR_NUMBER_NEWSTART, bNewStartChecked));
const sal_Int16 nStartAt = static_cast<sal_Int16>(m_xNewStartNF->get_value());
rSet->Put(SfxInt16Item(ATTR_NUMBER_NEWSTART_AT, bNumberNewStartChecked && bNewStartChecked ? nStartAt : -1));
}
return mbModified;
}
void SdParagraphNumTabPage::Reset( const SfxItemSet* rSet )
{
SfxItemState eItemState = rSet->GetItemState( ATTR_NUMBER_NEWSTART );
if(eItemState > SfxItemState::DEFAULT )
{
const SfxBoolItem& rStart = static_cast<const SfxBoolItem&>(rSet->Get(ATTR_NUMBER_NEWSTART));
m_xNewStartCB->set_state( rStart.GetValue() ? TRISTATE_TRUE : TRISTATE_FALSE );
}
else
{
m_xNewStartCB->set_state(TRISTATE_INDET);
m_xNewStartCB->set_sensitive(false);
}
m_xNewStartCB->save_state();
eItemState = rSet->GetItemState( ATTR_NUMBER_NEWSTART_AT);
if( eItemState > SfxItemState::DEFAULT )
{
sal_Int16 nNewStart = static_cast<const SfxInt16Item&>(rSet->Get(ATTR_NUMBER_NEWSTART_AT)).GetValue();
m_xNewStartNumberCB->set_active(-1 != nNewStart);
if(-1 == nNewStart)
nNewStart = 1;
m_xNewStartNF->set_value(nNewStart);
}
else
{
m_xNewStartCB->set_state(TRISTATE_INDET);
}
ImplNewStartHdl(*m_xNewStartCB);
m_xNewStartNF->save_value();
m_xNewStartNumberCB->save_state();
mbModified = false;
}
IMPL_LINK_NOARG(SdParagraphNumTabPage, ImplNewStartHdl, weld::Button&, void)
{
bool bEnable = m_xNewStartCB->get_active();
m_xNewStartNumberCB->set_sensitive(bEnable);
m_xNewStartNF->set_sensitive(bEnable && m_xNewStartNumberCB->get_active());
}
SdParagraphDlg::SdParagraphDlg(weld::Window* pParent, const SfxItemSet* pAttr)
: SfxTabDialogController(pParent, "modules/sdraw/ui/drawparadialog.ui",
"DrawParagraphPropertiesDialog", pAttr)
{
AddTabPage( "labelTP_PARA_STD", RID_SVXPAGE_STD_PARAGRAPH);
SvtCJKOptions aCJKOptions;
if( aCJKOptions.IsAsianTypographyEnabled() )
AddTabPage( "labelTP_PARA_ASIAN", RID_SVXPAGE_PARA_ASIAN);
else
RemoveTabPage( "labelTP_PARA_ASIAN" );
AddTabPage( "labelTP_PARA_ALIGN", RID_SVXPAGE_ALIGN_PARAGRAPH);
static const bool bShowParaNumbering = ( getenv( "SD_SHOW_NUMBERING_PAGE" ) != nullptr );
if( bShowParaNumbering )
AddTabPage( "labelNUMBERING", SdParagraphNumTabPage::Create, SdParagraphNumTabPage::GetRanges );
else
RemoveTabPage( "labelNUMBERING" );
AddTabPage("labelTP_TABULATOR", RID_SVXPAGE_TABULATOR);
}
void SdParagraphDlg::PageCreated(const OString& rId, SfxTabPage &rPage)
{
SfxAllItemSet aSet(*(GetInputSetImpl()->GetPool()));<--- The scope of the variable 'aSet' can be reduced. [+]The scope of the variable 'aSet' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
if (rId == "labelTP_PARA_STD")
{
aSet.Put(SfxUInt32Item(SID_SVXSTDPARAGRAPHTABPAGE_ABSLINEDIST, MM50/2));
rPage.PageCreated(aSet);
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|