/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
* This file is part of the LibreOffice project.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
* This file incorporates work covered by the following license notice:
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
DdeString::DdeString( DWORD hDdeInst, const OUString& r)
hString = DdeCreateStringHandleW( hDdeInst, o3tl::toW(r.getStr()), CP_WINUNICODE );
<--- Variable 'hString' is assigned in constructor body. Consider performing initialization in initialization list. [+]
hInst = hDdeInst;
if ( hString )
DdeFreeStringHandle( hInst, hString );
bool DdeString::operator==( HSZ h )
return( !DdeCmpStringHandles( hString, h ) );
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'hString' a value by passing the value to the constructor in the initialization list.