1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
 * This file is part of the LibreOffice project.
 *
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 */

#include <memory>
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include "plugin.hxx"

/**
  Find calls to "delete x" where x is a field on an object.
  Should rather be using std::unique_ptr
*/

namespace {

class AutoMem:
    public loplugin::FilteringPlugin<AutoMem>
{
public:
    explicit AutoMem(loplugin::InstantiationData const & data): FilteringPlugin(data), mbInsideDestructor(false) {}

    virtual void run() override
    {
        TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
    }

    bool TraverseCXXDestructorDecl(CXXDestructorDecl* );
    bool VisitCXXDeleteExpr(const CXXDeleteExpr* );
private:
    bool mbInsideDestructor;
};

bool AutoMem::TraverseCXXDestructorDecl(CXXDestructorDecl* expr)
{
    mbInsideDestructor = true;
    bool ret = RecursiveASTVisitor::TraverseCXXDestructorDecl(expr);
    mbInsideDestructor = false;
    return ret;
}

bool AutoMem::VisitCXXDeleteExpr(const CXXDeleteExpr* expr)<--- The function 'VisitCXXDeleteExpr' is never used.
{
    if (ignoreLocation( expr ))
        return true;
    StringRef aFileName = getFileNameOfSpellingLoc(compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(expr)));
    if (loplugin::hasPathnamePrefix(aFileName, SRCDIR "/include/salhelper/")
        || loplugin::hasPathnamePrefix(aFileName, SRCDIR "/include/osl/")
        || loplugin::hasPathnamePrefix(aFileName, SRCDIR "/salhelper/")
        || loplugin::hasPathnamePrefix(aFileName, SRCDIR "/store/")
        || loplugin::hasPathnamePrefix(aFileName, SRCDIR "/sal/"))
        return true;

    if (mbInsideDestructor)
        return true;

    const ImplicitCastExpr* pCastExpr = dyn_cast<ImplicitCastExpr>(expr->getArgument());
    if (!pCastExpr)
        return true;
    const MemberExpr* pMemberExpr = dyn_cast<MemberExpr>(pCastExpr->getSubExpr());
    if (!pMemberExpr)
        return true;
    // ignore union games
    const FieldDecl* pFieldDecl = dyn_cast<FieldDecl>(pMemberExpr->getMemberDecl());
    if (!pFieldDecl)
        return true;
    TagDecl const * td = dyn_cast<TagDecl>(pFieldDecl->getDeclContext());
    if (td->isUnion())
        return true;

    report(
        DiagnosticsEngine::Warning,
        "calling delete on object field, rather use std::unique_ptr or std::scoped_ptr",
        compat::getBeginLoc(expr))
        << expr->getSourceRange();
    return true;
}

loplugin::Plugin::Registration< AutoMem > X("automem", false);

}

/* vim:set shiftwidth=4 softtabstop=4 expandtab: */