1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
 * This file is part of the LibreOffice project.
 *
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 */

#include <sal/config.h>

#include <ostream>

#include <rtl/string.hxx>
#include <rtl/ustring.hxx>

#define FOO "foo"

void f(std::ostream& s1)
{
    static char const foo[] = "foo";
    s1 << "foo"
       << "foo";
    // expected-error@-1 {{replace '<<' between string literals with juxtaposition}}
    s1 << "foo" << FOO;
    // expected-error@-1 {{replace '<<' between string literals with juxtaposition}}
    s1 << "foo" << foo;
    s1 << "foo" << OString("foo");
    // expected-error@-1 {{replace '<<' between string literals with juxtaposition}}
    s1 << "foo" << OString(FOO);
    // expected-error@-1 {{replace '<<' between string literals with juxtaposition}}
    s1 << "foo" << OString(foo);
    s1 << "foo" << OUString("foo");
    // expected-error@-1 {{replace '<<' between string literals with juxtaposition}}
    s1 << "foo" << OUString(FOO);
    // expected-error@-1 {{replace '<<' between string literals with juxtaposition}}
    s1 << "foo" << OUString(foo);
    s1 << "foo" << OUStringLiteral("foo"); //TODO: warn too, OUStringLiteral wrapped in OUString
    s1 << "foo" << OUStringLiteral(FOO); //TODO: warn too, OUStringLiteral wrapped in OUString
    s1 << "foo" << OUStringLiteral(foo);
    OString s2;
    s2 = "foo" + OString("foo");<--- Variable 's2' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s2 = "foo" + OString(FOO);<--- Variable 's2' is reassigned a value before the old one has been used.<--- Variable 's2' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s2 = "foo" + OString(foo);<--- Variable 's2' is reassigned a value before the old one has been used.<--- Variable 's2' is reassigned a value before the old one has been used.
    s2 = "foo" + OStringLiteral("foo");<--- Variable 's2' is reassigned a value before the old one has been used.<--- Variable 's2' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s2 = "foo" + OStringLiteral(FOO);<--- Variable 's2' is reassigned a value before the old one has been used.<--- Variable 's2' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s2 = "foo" + OStringLiteral(foo);<--- Variable 's2' is reassigned a value before the old one has been used.<--- Variable 's2' is assigned a value that is never used.
    OUString s3;
    s3 = "foo" + OUString("foo");<--- Variable 's3' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s3 = "foo" + OUString(FOO);<--- Variable 's3' is reassigned a value before the old one has been used.<--- Variable 's3' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s3 = "foo" + OUString(foo);<--- Variable 's3' is reassigned a value before the old one has been used.<--- Variable 's3' is reassigned a value before the old one has been used.
    s3 = "foo" + OUStringLiteral("foo");<--- Variable 's3' is reassigned a value before the old one has been used.<--- Variable 's3' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s3 = "foo" + OUStringLiteral(FOO);<--- Variable 's3' is reassigned a value before the old one has been used.<--- Variable 's3' is reassigned a value before the old one has been used.
    // expected-error@-1 {{replace '+' between string literals with juxtaposition}}
    s3 = "foo" + OUStringLiteral(foo);<--- Variable 's3' is reassigned a value before the old one has been used.<--- Variable 's3' is assigned a value that is never used.
}

/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */