1
   2
   3
   4
   5
   6
   7
   8
   9
  10
  11
  12
  13
  14
  15
  16
  17
  18
  19
  20
  21
  22
  23
  24
  25
  26
  27
  28
  29
  30
  31
  32
  33
  34
  35
  36
  37
  38
  39
  40
  41
  42
  43
  44
  45
  46
  47
  48
  49
  50
  51
  52
  53
  54
  55
  56
  57
  58
  59
  60
  61
  62
  63
  64
  65
  66
  67
  68
  69
  70
  71
  72
  73
  74
  75
  76
  77
  78
  79
  80
  81
  82
  83
  84
  85
  86
  87
  88
  89
  90
  91
  92
  93
  94
  95
  96
  97
  98
  99
 100
 101
 102
 103
 104
 105
 106
 107
 108
 109
 110
 111
 112
 113
 114
 115
 116
 117
 118
 119
 120
 121
 122
 123
 124
 125
 126
 127
 128
 129
 130
 131
 132
 133
 134
 135
 136
 137
 138
 139
 140
 141
 142
 143
 144
 145
 146
 147
 148
 149
 150
 151
 152
 153
 154
 155
 156
 157
 158
 159
 160
 161
 162
 163
 164
 165
 166
 167
 168
 169
 170
 171
 172
 173
 174
 175
 176
 177
 178
 179
 180
 181
 182
 183
 184
 185
 186
 187
 188
 189
 190
 191
 192
 193
 194
 195
 196
 197
 198
 199
 200
 201
 202
 203
 204
 205
 206
 207
 208
 209
 210
 211
 212
 213
 214
 215
 216
 217
 218
 219
 220
 221
 222
 223
 224
 225
 226
 227
 228
 229
 230
 231
 232
 233
 234
 235
 236
 237
 238
 239
 240
 241
 242
 243
 244
 245
 246
 247
 248
 249
 250
 251
 252
 253
 254
 255
 256
 257
 258
 259
 260
 261
 262
 263
 264
 265
 266
 267
 268
 269
 270
 271
 272
 273
 274
 275
 276
 277
 278
 279
 280
 281
 282
 283
 284
 285
 286
 287
 288
 289
 290
 291
 292
 293
 294
 295
 296
 297
 298
 299
 300
 301
 302
 303
 304
 305
 306
 307
 308
 309
 310
 311
 312
 313
 314
 315
 316
 317
 318
 319
 320
 321
 322
 323
 324
 325
 326
 327
 328
 329
 330
 331
 332
 333
 334
 335
 336
 337
 338
 339
 340
 341
 342
 343
 344
 345
 346
 347
 348
 349
 350
 351
 352
 353
 354
 355
 356
 357
 358
 359
 360
 361
 362
 363
 364
 365
 366
 367
 368
 369
 370
 371
 372
 373
 374
 375
 376
 377
 378
 379
 380
 381
 382
 383
 384
 385
 386
 387
 388
 389
 390
 391
 392
 393
 394
 395
 396
 397
 398
 399
 400
 401
 402
 403
 404
 405
 406
 407
 408
 409
 410
 411
 412
 413
 414
 415
 416
 417
 418
 419
 420
 421
 422
 423
 424
 425
 426
 427
 428
 429
 430
 431
 432
 433
 434
 435
 436
 437
 438
 439
 440
 441
 442
 443
 444
 445
 446
 447
 448
 449
 450
 451
 452
 453
 454
 455
 456
 457
 458
 459
 460
 461
 462
 463
 464
 465
 466
 467
 468
 469
 470
 471
 472
 473
 474
 475
 476
 477
 478
 479
 480
 481
 482
 483
 484
 485
 486
 487
 488
 489
 490
 491
 492
 493
 494
 495
 496
 497
 498
 499
 500
 501
 502
 503
 504
 505
 506
 507
 508
 509
 510
 511
 512
 513
 514
 515
 516
 517
 518
 519
 520
 521
 522
 523
 524
 525
 526
 527
 528
 529
 530
 531
 532
 533
 534
 535
 536
 537
 538
 539
 540
 541
 542
 543
 544
 545
 546
 547
 548
 549
 550
 551
 552
 553
 554
 555
 556
 557
 558
 559
 560
 561
 562
 563
 564
 565
 566
 567
 568
 569
 570
 571
 572
 573
 574
 575
 576
 577
 578
 579
 580
 581
 582
 583
 584
 585
 586
 587
 588
 589
 590
 591
 592
 593
 594
 595
 596
 597
 598
 599
 600
 601
 602
 603
 604
 605
 606
 607
 608
 609
 610
 611
 612
 613
 614
 615
 616
 617
 618
 619
 620
 621
 622
 623
 624
 625
 626
 627
 628
 629
 630
 631
 632
 633
 634
 635
 636
 637
 638
 639
 640
 641
 642
 643
 644
 645
 646
 647
 648
 649
 650
 651
 652
 653
 654
 655
 656
 657
 658
 659
 660
 661
 662
 663
 664
 665
 666
 667
 668
 669
 670
 671
 672
 673
 674
 675
 676
 677
 678
 679
 680
 681
 682
 683
 684
 685
 686
 687
 688
 689
 690
 691
 692
 693
 694
 695
 696
 697
 698
 699
 700
 701
 702
 703
 704
 705
 706
 707
 708
 709
 710
 711
 712
 713
 714
 715
 716
 717
 718
 719
 720
 721
 722
 723
 724
 725
 726
 727
 728
 729
 730
 731
 732
 733
 734
 735
 736
 737
 738
 739
 740
 741
 742
 743
 744
 745
 746
 747
 748
 749
 750
 751
 752
 753
 754
 755
 756
 757
 758
 759
 760
 761
 762
 763
 764
 765
 766
 767
 768
 769
 770
 771
 772
 773
 774
 775
 776
 777
 778
 779
 780
 781
 782
 783
 784
 785
 786
 787
 788
 789
 790
 791
 792
 793
 794
 795
 796
 797
 798
 799
 800
 801
 802
 803
 804
 805
 806
 807
 808
 809
 810
 811
 812
 813
 814
 815
 816
 817
 818
 819
 820
 821
 822
 823
 824
 825
 826
 827
 828
 829
 830
 831
 832
 833
 834
 835
 836
 837
 838
 839
 840
 841
 842
 843
 844
 845
 846
 847
 848
 849
 850
 851
 852
 853
 854
 855
 856
 857
 858
 859
 860
 861
 862
 863
 864
 865
 866
 867
 868
 869
 870
 871
 872
 873
 874
 875
 876
 877
 878
 879
 880
 881
 882
 883
 884
 885
 886
 887
 888
 889
 890
 891
 892
 893
 894
 895
 896
 897
 898
 899
 900
 901
 902
 903
 904
 905
 906
 907
 908
 909
 910
 911
 912
 913
 914
 915
 916
 917
 918
 919
 920
 921
 922
 923
 924
 925
 926
 927
 928
 929
 930
 931
 932
 933
 934
 935
 936
 937
 938
 939
 940
 941
 942
 943
 944
 945
 946
 947
 948
 949
 950
 951
 952
 953
 954
 955
 956
 957
 958
 959
 960
 961
 962
 963
 964
 965
 966
 967
 968
 969
 970
 971
 972
 973
 974
 975
 976
 977
 978
 979
 980
 981
 982
 983
 984
 985
 986
 987
 988
 989
 990
 991
 992
 993
 994
 995
 996
 997
 998
 999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
 * This file is part of the LibreOffice project.
 *
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 */

#include <memory>
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include "plugin.hxx"
#include "check.hxx"

/**
  Find destructors that only contain a single call to delete of a field. In which
  case that field should really be managed by unique_ptr.
*/

namespace {

class UseUniquePtr:
    public loplugin::FilteringPlugin<UseUniquePtr>
{
public:
    explicit UseUniquePtr(loplugin::InstantiationData const & data):
        FilteringPlugin(data) {}

    virtual void run() override
    {
        fn = handler.getMainFileName();
        loplugin::normalizeDotDotInFilePath(fn);
        // can't change these because we pass them down to the SfxItemPool stuff
        if (fn == SRCDIR "/sc/source/core/data/docpool.cxx")<--- first condition
            return;
        // this just too clever for me
        if (fn == SRCDIR "/sc/source/core/tool/chgtrack.cxx")<--- second condition<--- first condition
            return;
        // too clever
        if (fn == SRCDIR "/pyuno/source/module/pyuno_runtime.cxx")<--- second condition<--- first condition
            return;
        // m_pExampleSet here is very badly managed. sometimes it is owning, sometimes not,
        // and the logic depends on overriding methods.
        if (fn == SRCDIR "/sfx2/source/dialog/tabdlg.cxx")<--- second condition<--- first condition
            return;
        // pLongArr is being deleted here because we temporarily overwrite a pointer to someone else's buffer, with a pointer
        // to our own buffer
        if (fn == SRCDIR "/editeng/source/misc/txtrange.cxx")<--- second condition<--- first condition
            return;
        // can't use std::set<std::unique_ptr<>> until C++14
        if (fn == SRCDIR "/editeng/source/misc/svxacorr.cxx")<--- second condition<--- first condition
            return;
        // horrible horrible spawn of evil ownership and deletion here
        if (fn == SRCDIR "/sfx2/source/view/ipclient.cxx")<--- second condition<--- first condition
            return;
        // sometimes it owns, sometimes it doesn't
        if (fn == SRCDIR "/editeng/source/misc/svxacorr.cxx")<--- second condition<--- first condition
            return;
        // SwDoc::m_PageDescs has weird handling
        if (fn == SRCDIR "/sw/source/core/doc/docnew.cxx")<--- second condition<--- first condition
            return;
        // SwRedlineData::pNext and pExtraData have complex handling
        if (fn == SRCDIR "/sw/source/core/doc/docredln.cxx")<--- second condition<--- first condition
            return;
        // ScTempDocSource::pTempDoc
        if (fn == SRCDIR "/sc/source/ui/unoobj/funcuno.cxx")<--- second condition<--- first condition<--- first condition
            return;
        // SwAttrIter::m_pFont
        if (fn == SRCDIR "/sw/source/core/text/itratr.cxx"<--- second condition
            || fn == SRCDIR "/sw/source/core/text/redlnitr.cxx")<--- second condition
            return;
        // SwWrongList
        if (fn == SRCDIR "/sw/source/core/text/wrong.cxx")<--- first condition
            return;
        // SwLineLayout::m_pNext
        if (fn == SRCDIR "/sw/source/core/text/porlay.cxx")<--- second condition<--- first condition
            return;
        // ODatabaseExport::m_aDestColumns
        if (fn == SRCDIR "/dbaccess/source/ui/misc/DExport.cxx")<--- second condition<--- first condition
            return;
        // ScTabView::pDrawActual and pDrawOld
        if (fn == SRCDIR "/sc/source/ui/view/tabview5.cxx")<--- second condition<--- first condition
            return;
        // SwHTMLParser::m_pPendStack
        if (fn == SRCDIR "/sw/source/filter/html/htmlcss1.cxx")<--- second condition<--- first condition<--- first condition
            return;
        // Visual Studio 2017 has trouble with these
        if (fn == SRCDIR "/comphelper/source/property/MasterPropertySet.cxx"<--- second condition
            || fn == SRCDIR "/comphelper/source/property/MasterPropertySetInfo.cxx")<--- second condition
            return;
        // SwTableLine::m_aBoxes
        if (fn == SRCDIR "/sw/source/core/table/swtable.cxx")<--- first condition
            return;
        // SwHTMLParser::m_pFormImpl
        if (fn == SRCDIR "/sw/source/filter/html/htmlform.cxx")<--- second condition<--- first condition
            return;
        // SwHTMLParser::m_pPendStack, pNext
        if (fn == SRCDIR "/sw/source/filter/html/htmltab.cxx")<--- second condition<--- first condition
            return;
        // SaveLine::pBox, pNext
        if (fn == SRCDIR "/sw/source/core/undo/untbl.cxx")<--- second condition<--- first condition
            return;
        // RedlineInfo::pNextRedline
        if (fn == SRCDIR "/sw/source/filter/xml/XMLRedlineImportHelper.cxx")<--- second condition<--- first condition
            return;
        // SfxObjectShell::pMedium
        if (fn == SRCDIR "/sfx2/source/doc/objxtor.cxx")<--- second condition<--- first condition
            return;
        // various
        if (fn == SRCDIR "/sw/source/filter/ww8/wrtww8.cxx")<--- second condition<--- first condition
            return;
        // WW8TabBandDesc
        if (fn == SRCDIR "/sw/source/filter/ww8/ww8par2.cxx")<--- second condition<--- first condition
            return;
        // ZipOutputStream, ownership of ZipEntry is horribly complicated here
        if (fn == SRCDIR "/package/source/zipapi/ZipOutputStream.cxx")<--- second condition<--- first condition
            return;
        // custom deleter
        if (fn == SRCDIR "/sal/rtl/locale.cxx")<--- second condition<--- first condition<--- first condition
            return;
        // std::vector<ScLookupCacheMap*> is tricky, changing it would require moving lots of class definitions around
        if (fn == SRCDIR "/sc/source/core/data/documen2.cxx"<--- second condition
            || fn == SRCDIR "/sc/source/core/tool/interpretercontext.cxx")<--- second condition
            return;

        TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
    }

    bool VisitFunctionDecl(const FunctionDecl* );
    bool VisitCXXDeleteExpr(const CXXDeleteExpr* );
    bool TraverseFunctionDecl(FunctionDecl* );
    bool TraverseCXXDeductionGuideDecl(CXXDeductionGuideDecl* );
    bool TraverseCXXMethodDecl(CXXMethodDecl* );
    bool TraverseCXXConstructorDecl(CXXConstructorDecl* );
    bool TraverseCXXConversionDecl(CXXConversionDecl* );
    bool TraverseCXXDestructorDecl(CXXDestructorDecl* );
    bool TraverseConstructorInitializer(CXXCtorInitializer*);

private:
    void CheckCompoundStmt(const FunctionDecl*, const CompoundStmt* );
    void CheckIfStmt(const FunctionDecl*, const IfStmt* );
    void CheckCXXForRangeStmt(const FunctionDecl*, const CXXForRangeStmt* );
    void CheckLoopDelete(const FunctionDecl*, const Stmt* );
    void CheckLoopDelete(const FunctionDecl*, const CXXDeleteExpr* );
    void CheckDeleteExpr(const FunctionDecl*, const CXXDeleteExpr*);
    void CheckDeleteLocalVar(const FunctionDecl*, const CXXDeleteExpr*, const VarDecl*);
    void CheckDeleteParmVar(const CXXDeleteExpr*, const ParmVarDecl*);
    void CheckParenExpr(const FunctionDecl*, const ParenExpr*);
    void CheckMemberDeleteExpr(const FunctionDecl*, const CXXDeleteExpr*,
        const MemberExpr*, StringRef message);
    FunctionDecl const * mpCurrentFunctionDecl = nullptr;
    std::string fn;
};

bool UseUniquePtr::VisitFunctionDecl(const FunctionDecl* functionDecl)
{
    if (ignoreLocation(functionDecl))
        return true;
    if (isInUnoIncludeFile(functionDecl))
        return true;

    const CompoundStmt* compoundStmt = dyn_cast_or_null< CompoundStmt >( functionDecl->getBody() );
    if (!compoundStmt || compoundStmt->size() == 0)
        return true;

    CheckCompoundStmt(functionDecl, compoundStmt);

    return true;
}

/**
 * check for simple call to delete i.e. direct unconditional call, or if-guarded call
 */
void UseUniquePtr::CheckCompoundStmt(const FunctionDecl* functionDecl, const CompoundStmt* compoundStmt)
{
    for (auto i = compoundStmt->body_begin(); i != compoundStmt->body_end(); ++i)
    {
        if (auto cxxForRangeStmt = dyn_cast<CXXForRangeStmt>(*i))
            CheckCXXForRangeStmt(functionDecl, cxxForRangeStmt);
        else if (auto forStmt = dyn_cast<ForStmt>(*i))
            CheckLoopDelete(functionDecl, forStmt->getBody());
        else if (auto whileStmt = dyn_cast<WhileStmt>(*i))
            CheckLoopDelete(functionDecl, whileStmt->getBody());
        // check for unconditional inner compound statements
        else if (auto innerCompoundStmt = dyn_cast<CompoundStmt>(*i))
            CheckCompoundStmt(functionDecl, innerCompoundStmt);
        else if (auto deleteExpr = dyn_cast<CXXDeleteExpr>(*i))
            CheckDeleteExpr(functionDecl, deleteExpr);
        else if (auto parenExpr = dyn_cast<ParenExpr>(*i))
            CheckParenExpr(functionDecl, parenExpr);
        else if (auto ifStmt = dyn_cast<IfStmt>(*i))
            CheckIfStmt(functionDecl, ifStmt);
    }
}

// Check for conditional deletes like:
//     if (m_pField != nullptr) delete m_pField;
void UseUniquePtr::CheckIfStmt(const FunctionDecl* functionDecl, const IfStmt* ifStmt)
{
    auto cond = ifStmt->getCond()->IgnoreImplicit();
    if (auto ifCondMemberExpr = dyn_cast<MemberExpr>(cond))
    {
        // ignore "if (bMine)"
        if (!loplugin::TypeCheck(ifCondMemberExpr->getType()).Pointer())
            return;
        // good
    }
    else if (auto binaryOp = dyn_cast<BinaryOperator>(cond))
    {
        if (!isa<MemberExpr>(binaryOp->getLHS()->IgnoreImplicit()))
            return;
        if (!isa<CXXNullPtrLiteralExpr>(binaryOp->getRHS()->IgnoreImplicit()))
            return;
        // good
    }
    else // ignore anything more complicated
        return;

    auto deleteExpr = dyn_cast<CXXDeleteExpr>(ifStmt->getThen());
    if (deleteExpr)
    {
        CheckDeleteExpr(functionDecl, deleteExpr);
        return;
    }

    auto parenExpr = dyn_cast<ParenExpr>(ifStmt->getThen());<--- Shadowed declaration
    if (parenExpr)
    {
        CheckParenExpr(functionDecl, parenExpr);
        return;
    }

    auto ifThenCompoundStmt = dyn_cast<CompoundStmt>(ifStmt->getThen());
    if (!ifThenCompoundStmt)
        return;
    for (auto j = ifThenCompoundStmt->body_begin(); j != ifThenCompoundStmt->body_end(); ++j)
    {
        auto ifDeleteExpr = dyn_cast<CXXDeleteExpr>(*j);
        if (ifDeleteExpr)
            CheckDeleteExpr(functionDecl, ifDeleteExpr);
        ParenExpr const * parenExpr = dyn_cast<ParenExpr>(*j);<--- Shadow variable
        if (parenExpr)
            CheckParenExpr(functionDecl, parenExpr);
    }
}

void UseUniquePtr::CheckDeleteExpr(const FunctionDecl* functionDecl, const CXXDeleteExpr* deleteExpr)
{
    auto deleteExprArg = deleteExpr->getArgument()->IgnoreParens()->IgnoreImplicit();


    if (const MemberExpr* memberExpr = dyn_cast<MemberExpr>(deleteExprArg))
    {
        // ignore delete static_cast<T>(p)->other;
        if (!isa<CXXThisExpr>(memberExpr->getBase()->IgnoreCasts()))
            return;
        // don't always own this
        if (fn == SRCDIR "/editeng/source/editeng/impedit2.cxx")<--- first condition
            return;
        // this member needs to get passed via an extern "C" API
        if (fn == SRCDIR "/sd/source/filter/sdpptwrp.cxx")<--- second condition<--- first condition
            return;
        // ownership complicated between this and the group
        if (fn == SRCDIR "/sc/source/core/data/formulacell.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/sw/source/filter/html/parcss1.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/sw/source/filter/writer/writer.cxx")<--- second condition<--- first condition
            return;
        // complicated
        if (fn == SRCDIR "/sc/source/filter/html/htmlpars.cxx")<--- second condition<--- first condition
            return;
        // complicated pimpl stuff in SalLayoutGlyphs
        if (fn == SRCDIR "/vcl/source/gdi/impglyphitem.cxx")<--- second condition
            return;

        CheckMemberDeleteExpr(functionDecl, deleteExpr, memberExpr,
            "unconditional call to delete on a member, should be using std::unique_ptr");
        return;
    }

    const ArraySubscriptExpr* arrayExpr = dyn_cast<ArraySubscriptExpr>(deleteExprArg);
    if (arrayExpr)
    {
       auto baseMemberExpr = dyn_cast<MemberExpr>(arrayExpr->getBase()->IgnoreParens()->IgnoreImplicit());
       if (baseMemberExpr)
            CheckMemberDeleteExpr(functionDecl, deleteExpr, baseMemberExpr,
                "unconditional call to delete on an array member, should be using std::unique_ptr");
    }
}

template<typename T>
bool any_equal(std::string const & needle, T first) {
  return needle == first;
}

template<typename T, typename... Args>
bool any_equal(std::string const & needle, T first, Args... args) {
  return needle == first || any_equal(needle, args...);
}

void UseUniquePtr::CheckDeleteLocalVar(const FunctionDecl* functionDecl, const CXXDeleteExpr* deleteExpr, const VarDecl* varDecl)
{
    // ignore globals for now
    if (varDecl->hasGlobalStorage())
        return;

    // Ignore times when we are casting from void* to init the var, normally indicates
    // some complex memory management.
    if (varDecl->getInit())
    {
        if (auto explicitCast = dyn_cast<ExplicitCastExpr>(varDecl->getInit()))
        {
            if (loplugin::TypeCheck(explicitCast->getSubExpr()->getType()).Pointer().Void())
                return;
        }
    }

    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/sal/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/comphelper/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/cppuhelper/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/libreofficekit/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/vcl/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/sc/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/sfx2/qa/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/smoketest/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, WORKDIR))
        return;
    // linked lists
    if (fn == SRCDIR "/vcl/source/gdi/regband.cxx")
        return;
    // this thing relies on explicit delete
    if (loplugin::TypeCheck(varDecl->getType()).Pointer().Class("VersionCompat").GlobalNamespace())
        return;
    if (loplugin::TypeCheck(varDecl->getType()).Pointer().Class("IMapCompat").GlobalNamespace())
        return;
    // passing data to gtk API and I can't figure out the types
    if (fn == SRCDIR "/vcl/unx/gtk3/gtk3gtkdata.cxx"
        || fn == SRCDIR "/vcl/unx/gtk/gtkdata.cxx")
        return;
    // sometimes this stuff is held by tools::SvRef, sometimes by std::unique_ptr .....
    if (fn == SRCDIR "/sot/source/unoolestorage/xolesimplestorage.cxx")<--- first condition
        return;
    // don't feel like messing with this chunk of sfx2
    if (fn == SRCDIR "/sfx2/source/appl/appinit.cxx")<--- second condition<--- first condition
        return;
    if (fn == SRCDIR "/svx/source/svdraw/svdobj.cxx")<--- second condition<--- first condition
        return;
    if (fn == SRCDIR "/svx/source/svdraw/svdmodel.cxx")<--- second condition<--- first condition
        return;
    // linked list
    if (fn == SRCDIR "/basic/source/comp/parser.cxx")<--- second condition<--- first condition
        return;
    if (fn == SRCDIR "/basic/source/runtime/runtime.cxx")<--- second condition<--- first condition
        return;
    // just horrible
    if (fn == SRCDIR "/svx/source/form/filtnav.cxx")<--- second condition<--- first condition
        return;
    // using clucene macros
    if (fn == SRCDIR "/helpcompiler/source/HelpSearch.cxx")<--- second condition<--- first condition
        return;
    // linked list
    if (fn == SRCDIR "/filter/source/graphicfilter/ios2met/ios2met.cxx")<--- second condition<--- first condition
        return;
    // no idea what this is trying to do
    if (fn == SRCDIR "/cui/source/customize/SvxMenuConfigPage.cxx")<--- second condition<--- first condition
        return;
    // I cannot follow the ownership of OSQLParseNode's
    if (fn == SRCDIR "/dbaccess/source/core/api/SingleSelectQueryComposer.cxx")<--- second condition<--- first condition
        return;
    if (fn == SRCDIR "/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx")<--- second condition<--- first condition
        return;
    // linked list
    if (fn == SRCDIR "/formula/source/core/api/FormulaCompiler.cxx")<--- second condition<--- first condition
        return;
    // smuggling data around via SvxFontListItem
    if (fn == SRCDIR "/extensions/source/propctrlr/fontdialog.cxx")<--- second condition<--- first condition
        return;
    // atomics
    if (fn == SRCDIR "/sc/source/ui/docshell/documentlinkmgr.cxx")<--- second condition<--- first condition
        return;
    // finicky
    if (fn == SRCDIR "/sc/source/core/data/stlpool.cxx")<--- second condition<--- first condition
        return;
    // macros
    if (fn == SRCDIR "/sc/source/core/tool/autoform.cxx")<--- second condition<--- first condition
        return;
    // unsure about ownership
    if (fn == SRCDIR "/xmlsecurity/source/framework/saxeventkeeperimpl.cxx")<--- second condition<--- first condition
        return;
    // ScTokenArray ownership complicated between this and the group
    if (fn == SRCDIR "/sc/source/core/data/formulacell.cxx")<--- second condition<--- first condition
        return;
    // macros
    if (fn == SRCDIR "/sw/source/core/doc/tblafmt.cxx")<--- second condition<--- first condition
        return;
    // more ScTokenArray
    if (fn == SRCDIR "/sc/source/ui/unoobj/tokenuno.cxx")<--- second condition<--- first condition
        return;
    // SwDoc::DelTextFormatColl
    if (fn == SRCDIR "/sw/source/core/doc/docfmt.cxx")<--- second condition<--- first condition
        return;
    // SwRootFrame::CalcFrameRects
    if (fn == SRCDIR "/sw/source/core/layout/trvlfrm.cxx")<--- second condition<--- first condition
        return;
    // crazy code
    if (fn == SRCDIR "/sw/source/core/undo/SwUndoPageDesc.cxx")<--- second condition<--- first condition
        return;
    // unsure about the SwLinePortion ownership
    if (fn == SRCDIR "/sw/source/core/text/itrform2.cxx")<--- second condition<--- first condition
        return;
    // can't follow the ownership
    if (fn == SRCDIR "/sw/source/filter/html/htmlatr.cxx")<--- second condition<--- first condition
        return;
    // SwTextFormatter::BuildMultiPortion complicated
    if (fn == SRCDIR "/sw/source/core/text/pormulti.cxx")<--- second condition<--- first condition
        return;
    // SwXMLExport::ExportTableLines
    if (fn == SRCDIR "/sw/source/filter/xml/xmltble.cxx")<--- second condition<--- first condition
        return;
    // SwPagePreview::~SwPagePreview
    if (fn == SRCDIR "/sw/source/uibase/uiview/pview.cxx")<--- second condition<--- first condition
        return;
    // alloc/free routines for the hand constructed virtual function table
    if (fn == SRCDIR "/sal/textenc/convertisciidevangari.cxx")<--- second condition
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/bridges/"))
        return;
    // bootstrap_map
    if (fn == SRCDIR "/sal/rtl/bootstrap.cxx")
        return;
    // too complicated for my small brain
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/cppu/"))
        return;
    // linked list
    if (fn == SRCDIR "/vcl/source/gdi/octree.cxx")<--- first condition
        return;
    // linked list
    if (fn == SRCDIR "/vcl/source/filter/graphicfilter.cxx")<--- second condition<--- first condition
        return;
    // linked list
    if (fn == SRCDIR "/svtools/source/control/ctrltool.cxx")<--- second condition<--- first condition
        return;
    // complicated
    if (fn == SRCDIR "/sfx2/source/control/msgpool.cxx")<--- second condition<--- first condition
        return;
    // complicated
    if (fn == SRCDIR "/svx/source/sdr/contact/objectcontact.cxx")<--- second condition<--- first condition
        return;
    // memory management in this module is a mess
    if (fn == SRCDIR "/idlc/source/aststack.cxx")<--- second condition<--- first condition
        return;
    // complicated
    if (fn == SRCDIR "/cui/source/customize/cfg.cxx")<--- second condition<--- first condition
        return;
    // linked list
    if (fn == SRCDIR "/lotuswordpro/source/filter/lwpfribptr.cxx")<--- second condition
        return;
    // complicated
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/connectivity/source/drivers/file/"))
        return;
    // complicated
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/unodevtools/source/skeletonmaker/"))
        return;

    llvm::StringRef parentName;
    if (auto cxxMethodDecl = dyn_cast<CXXMethodDecl>(functionDecl))
    {
        parentName = cxxMethodDecl->getParent()->getName();
    }

    // no idea what is going on here
    if (parentName == "ScChangeActionLinkEntry")
        return;
    // ok
    if (parentName == "SfxItemSet" || parentName == "SfxItemPool")
        return;
    // linked list
    if (parentName == "ScFunctionList" || parentName == "SwNodes"
        || parentName == "SwUnoCursor" || parentName == "SortedResultSet"
        || parentName == "Atom" || parentName == "RegionBand" || parentName == "WMFWriter"
        || parentName == "Scheduler" || parentName == "OpenGLContext"
        || parentName == "WizardDialog")
        return;
    // manual ref counting
    if (parentName == "ScBroadcastAreaSlot")
        return;
    // complicated
    if (any_equal(parentName, "SwFormatField", "FontPropertyBox", "SdFontPropertyBox",
        "SwHTMLParser", "PDFWriterImpl", "SbiParser", "DictionaryList", "SwGlossaryHdl", "SwGlossaryGroupDlg"))
        return;
    // ok
    if (any_equal(parentName, "SbTreeListBox"))
        return;

    if (functionDecl->getIdentifier())
    {
        std::string name = functionDecl->getName();
        if (!parentName.empty())
            name = std::string(parentName) + "::" + name;

        // custom deleters
        if (name == "Proxy_free" || name == "s_free" || name == "binuno_proxy_free")
            return;
        if (name == "SvpSalFrame::ReleaseGraphics")
            return;
        // don't feel like changing the API functions in registry
        if (name == "createRegistry" || name == "openRegistry" || name == "closeRegistry" || name == "destroyRegistry"
            || name == "reg_openRegistry")
            return;
        // linked list
        if (any_equal(name, "TypeWriter::createBlop", "ImplDeleteConfigData", "Config::DeleteGroup",
                "Config::DeleteKey", "E3dView::DoDepthArrange",
                "DXFBlocks::Clear", "DXFTables::Clear", "DXFEntities::Clear",
                "PSWriter::WritePS", "PSWriter::ImplWriteActions", "CUtList::Destroy",
                "ScBroadcastAreaSlotMachine::UpdateBroadcastAreas"))
            return;
        // ok
        if (any_equal(name, "write_uInt16s_FromOUString", "ProgressMonitor::removeText",
            "StgDirEntry::SetSize", "UCBStorage::CopyStorageElement_Impl"
            "OutputDevice::ImplDrawPolyPolygon", "OutputDevice::ImplDrawPolyPolygon",
            "ImplListBox::InsertEntry", "Edit::dispose",
            "ViewContact::deleteAllVOCs", "SfxViewFrame::ReleaseObjectShell_Impl",
            "SfxViewFrame::SwitchToViewShell_Impl", "OfaSmartTagOptionsTabPage::ClearListBox",
            "OfaSmartTagOptionsTabPage::FillItemSet", "doc_destroy", "lo_destroy",
            "callColumnFormatDialog"))
            return;
        // very dodgy
        if (any_equal(name, "UCBStorage::OpenStorage_Impl", "SdTransferable::GetData"))
            return;
        // complicated ownership
        if (any_equal(name, "ParseCMAP", "OpenGLSalBitmap::CreateTexture", "X11SalGraphicsImpl::drawAlphaBitmap"
            "SvEmbedTransferHelper::GetData", "ORoadmap::dispose",
            "BrowseBox::SetMode", "ExportDialog::GetFilterData", "disposeComVariablesForBasic",
            "ImpEditEngine::ImpRemoveParagraph", "FactoryImpl::createAdapter",
            "SfxStateCache::SetVisibleState", "SfxBindings::QueryState",
            "ViewContact::deleteAllVOCs", "SvxMSDffManager::ProcessObj", "SvEmbedTransferHelper::GetData",
            "SvXMLExportPropertyMapper::Filter_", "SdXMLExport::ImpGetOrCreatePageMasterInfo",
            "SfxDocumentDescPage::FillItemSet", "SfxCustomPropertiesPage::FillItemSet",
            "SfxCmisPropertiesPage::FillItemSet", "SfxObjectShell::DoSaveCompleted",
            "SfxObjectShell::DoSave_Impl", "SfxObjectShell::PreDoSaveAs_Impl", "SfxObjectShell::Save_Impl",
            "SfxFrame::DoClose_Impl", "SfxBaseModel::load",
            "SdrTextObj::TakeTextRect", "SdrTableObj::TakeTextRect", "SdrObjCustomShape::TakeTextRect",
            "CellProperties::ItemSetChanged", "CellProperties::ItemChange",
            "TableLayouter::SetBorder", "TableLayouter::ClearBorderLayout",
            "ImpXPolygon::Resize", "SvxTextEditSourceImpl::GetBackgroundTextForwarder",
            "Svx3DSceneObject::setPropertyValueImpl", "lcl_RemoveTextEditOutlinerViews",
            "SdrObjEditView::SdrEndTextEdit", "SvxShape::_setPropertyValue",
            "AccessibleShape::Init", "AccessibleCell::Init",
            "SdrTableRtfExporter::WriteCell", "GalleryItem::_getPropertyValues",
            "VMLExport::StartShape", "DrawingML::WriteText",
            "MtfTools::DrawText", "FormulaTokenArray::RewriteMissing",
            "OSQLParseNode::negateSearchCondition", "OSQLParseNodesContainer::clearAndDelete",
            "SdFilter::GetLibrarySymbol", "SdPage::SetObjText",
            "SdDrawDocument::InsertBookmarkAsPage", "SdDrawDocument::InsertBookmarkAsObject",
            "SdDrawDocument::RemoveUnnecessaryMasterPages",
            "ScTable::CopyConditionalFormat", "ScTable::ValidQuery",
            "ScTable::SetOptimalHeight", "ScTable::SetOptimalHeightOnly", "ScCompiler::CompileString",
            "ScProgress::DeleteInterpretProgress", "ScInterpreter::ScBase",
            "UCBStorage::CopyStorageElement_Impl", "X11SalGraphicsImpl::drawAlphaBitmap",
            "MasterPagesSelector::ClearPageSet", "View::IsPresObjSelected",
            "SdDrawPagesAccess::remove", "SdMasterPagesAccess::remove", "View::InsertData",
            "RemoteServer::execute", "Implementation::ReleaseOutlinerView",
            "SwFormat::CopyAttrs", "FinitCore", "SwCursorShell::MoveFieldType", "SwExtraPainter::PaintExtra",
            "SwMarginPortion::AdjustRight", "SwPaintQueue::Repaint", "SwTOXMgr::UpdateOrInsertTOX",
            "SwBaseShell::Execute", "WW8Export::WriteSdrTextObj"))
            return;
        // complicated delete
        if (name == "X11SalObject::CreateObject")
            return;
    }

    report(
         DiagnosticsEngine::Warning,
         "call to delete on a var, should be using std::unique_ptr",
         compat::getBeginLoc(deleteExpr))
         << deleteExpr->getSourceRange();
    report(
         DiagnosticsEngine::Note,
         "var is here",
         compat::getBeginLoc(varDecl))
         << varDecl->getSourceRange();
}

/**
 * Look for DELETEZ expressions.
 */
void UseUniquePtr::CheckParenExpr(const FunctionDecl* functionDecl, const ParenExpr* parenExpr)
{
    auto binaryOp = dyn_cast<BinaryOperator>(parenExpr->getSubExpr());
    if (!binaryOp || binaryOp->getOpcode() != BO_Comma)
        return;
    auto deleteExpr = dyn_cast<CXXDeleteExpr>(binaryOp->getLHS());
    if (!deleteExpr)
        return;
    CheckDeleteExpr(functionDecl, deleteExpr);
}

void UseUniquePtr::CheckLoopDelete(const FunctionDecl* functionDecl, const Stmt* bodyStmt)
{
    if (auto deleteExpr = dyn_cast<CXXDeleteExpr>(bodyStmt))
        CheckLoopDelete(functionDecl, deleteExpr);
    else if (auto compoundStmt = dyn_cast<CompoundStmt>(bodyStmt))
    {
        for (auto i = compoundStmt->body_begin(); i != compoundStmt->body_end(); ++i)
        {
            if (auto deleteExpr = dyn_cast<CXXDeleteExpr>(*i))
                CheckLoopDelete(functionDecl, deleteExpr);
        }
    }
}

void UseUniquePtr::CheckLoopDelete(const FunctionDecl* functionDecl, const CXXDeleteExpr* deleteExpr)
{
    const MemberExpr* memberExpr = nullptr;
    const VarDecl* varDecl = nullptr;
    const Expr* subExpr = deleteExpr->getArgument();
    // drill down looking for a MemberExpr
    for (;;)
    {
        subExpr = subExpr->IgnoreParens()->IgnoreImplicit();
        if ((memberExpr = dyn_cast<MemberExpr>(subExpr)))
        {
            if (memberExpr->getMemberDecl()->getName() == "first" || memberExpr->getMemberDecl()->getName() == "second")
            {
                subExpr = memberExpr->getBase();
                memberExpr = nullptr;
            }
            else
                break;
        }
        else if (auto declRefExpr = dyn_cast<DeclRefExpr>(subExpr))
        {
            if ((varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl())))
                break;
        }
        else if (auto arraySubscriptExpr = dyn_cast<ArraySubscriptExpr>(subExpr))
            subExpr = arraySubscriptExpr->getBase();
        else if (auto cxxOperatorCallExpr = dyn_cast<CXXOperatorCallExpr>(subExpr))
        {
            // look for deletes of an iterator object where the iterator is over a member field
            if (auto declRefExpr = dyn_cast<DeclRefExpr>(cxxOperatorCallExpr->getArg(0)->IgnoreImplicit()))
            {
                if (auto iterVarDecl = dyn_cast<VarDecl>(declRefExpr->getDecl()))
                {
                    auto init = iterVarDecl->getInit();
                    if (init)
                    {
                        init = compat::IgnoreImplicit(init);
                        if (!compat::CPlusPlus17(compiler.getLangOpts()))
                            if (auto x = dyn_cast<CXXConstructExpr>(init))
                                if (x->isElidable())
                                    init = compat::IgnoreImplicit(x->getArg(0));
                        if (auto x = dyn_cast<CXXConstructExpr>(init))
                            if (x->getNumArgs() == 1
                                || (x->getNumArgs() >= 2 && isa<CXXDefaultArgExpr>(x->getArg(1))))
                            {
                                init = compat::IgnoreImplicit(x->getArg(0));
                            }
                        if (auto x = dyn_cast<CXXMemberCallExpr>(init))
                            init = x->getImplicitObjectArgument()->IgnoreParenImpCasts();
                        if ((memberExpr = dyn_cast<MemberExpr>(init)))
                            break;
                        // look for deletes of an iterator object where the iterator is over a var
                        if (auto declRefExpr2 = dyn_cast<DeclRefExpr>(init))
                        {
                            if ((varDecl = dyn_cast<VarDecl>(declRefExpr2->getDecl())))
                                break;
                        }
                    }
                }
            }
            // look for deletes like "delete m_pField[0]"
            if (cxxOperatorCallExpr->getOperator() == OO_Subscript)
            {
                subExpr = cxxOperatorCallExpr->getArg(0)->IgnoreImplicit();
                if ((memberExpr = dyn_cast<MemberExpr>(subExpr)))
                    break;
                if (auto declRefExpr = dyn_cast<DeclRefExpr>(subExpr))
                {
                    if ((varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl())))
                        break;
                }
            }
            break;
        }
        else
           break;
    }

    if (memberExpr)
    {
        // OStorage_Impl::Commit very complicated ownership passing going on
        if (fn == SRCDIR "/package/source/xstor/xstorage.cxx")<--- first condition
            return;
        // complicated
        if (fn == SRCDIR "/vcl/source/gdi/print.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/basic/source/runtime/runtime.cxx")<--- second condition<--- first condition
            return;
        // complicated
        if (fn == SRCDIR "/sw/source/core/bastyp/swcache.cxx")<--- second condition
            return;

        CheckMemberDeleteExpr(functionDecl, deleteExpr, memberExpr, "rather manage this member with std::some_container<std::unique_ptr<T>>");
    }

    if (varDecl)
    {
        // ignore if the value for the var comes from somewhere else
        if (varDecl->hasInit() && isa<ExplicitCastExpr>(varDecl->getInit()->IgnoreImpCasts()))
            return;

        if (loplugin::hasPathnamePrefix(fn, SRCDIR "/vcl/qa/"))
            return;
        // linked list
        if (fn == SRCDIR "/registry/source/reflwrit.cxx")<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/tools/source/generic/config.cxx")<--- second condition<--- first condition
            return;
        // linked lists
        if (fn == SRCDIR "/vcl/source/gdi/regband.cxx")<--- second condition<--- first condition
            return;
        // linked lists
        if (fn == SRCDIR "/vcl/source/gdi/regionband.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/vcl/source/gdi/octree.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/vcl/source/app/scheduler.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/vcl/source/filter/wmf/wmfwr.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/vcl/source/filter/graphicfilter.cxx")<--- second condition<--- first condition
            return;
        // valid code
        if (fn == SRCDIR "/vcl/source/app/salvtables.cxx")<--- second condition<--- first condition
            return;
        // undo code is tricky
        if (fn == SRCDIR "/svl/source/undo/undo.cxx")<--- second condition<--- first condition
            return;
        // subclass that messes with parent class in constructor/destructor, yuck
        if (fn == SRCDIR "/svtools/source/contnr/imivctl1.cxx")<--- second condition<--- first condition
            return;
        // SQLParseNode
        if (fn == SRCDIR "/connectivity/source/parse/sqlnode.cxx")<--- second condition<--- first condition
            return;
        // the whole svx model/contact/view thing confuses me
        if (fn == SRCDIR "/svx/source/sdr/contact/viewcontact.cxx")<--- second condition<--- first condition
            return;
        if (fn == SRCDIR "/svx/source/sdr/contact/objectcontact.cxx")<--- second condition<--- first condition
            return;
        // no idea
        if (fn == SRCDIR "/svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx")<--- second condition<--- first condition
            return;
        // SdrUndo stuff
        if (fn == SRCDIR "/svx/source/svdraw/svdundo.cxx")<--- second condition<--- first condition
            return;
        // TODO the lazydelete stuff should probably just be ripped out altogether now that we have VclPtr
        if (fn == SRCDIR "/vcl/source/helper/lazydelete.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/filter/source/graphicfilter/idxf/dxfblkrd.cxx")<--- second condition<--- first condition
            return;
        if (fn == SRCDIR "/filter/source/graphicfilter/idxf/dxftblrd.cxx")<--- second condition<--- first condition
            return;
        if (fn == SRCDIR "/lotuswordpro/source/filter/utlist.cxx")<--- second condition<--- first condition
            return;
        if (fn == SRCDIR "/lotuswordpro/source/filter/lwpfribptr.cxx")<--- second condition<--- first condition
            return;
        // valid
        if (fn == SRCDIR "/sd/source/ui/sidebar/MasterPagesSelector.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/sd/source/filter/ppt/pptatom.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/sc/source/core/data/funcdesc.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/sw/source/core/crsr/crsrsh.cxx")<--- second condition<--- first condition
            return;
        // no idea
        if (fn == SRCDIR "/sw/source/core/docnode/nodes.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/sw/source/core/unocore/unocrsr.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/filter/source/graphicfilter/idxf/dxfentrd.cxx")<--- second condition<--- first condition
            return;
        // linked list
        if (fn == SRCDIR "/filter/source/graphicfilter/ios2met/ios2met.cxx")<--- second condition<--- first condition
            return;
        // sometimes owning, sometimes not
        if (fn == SRCDIR "/sw/qa/core/Test-BigPtrArray.cxx")<--- second condition
            return;

        report(
            DiagnosticsEngine::Warning,
            "loopdelete: rather manage this var with std::some_container<std::unique_ptr<T>>",
            compat::getBeginLoc(deleteExpr))
            << deleteExpr->getSourceRange();
        report(
            DiagnosticsEngine::Note,
            "var is here",
            compat::getBeginLoc(varDecl))
            << varDecl->getSourceRange();
    }
}

void UseUniquePtr::CheckCXXForRangeStmt(const FunctionDecl* functionDecl, const CXXForRangeStmt* cxxForRangeStmt)
{
    CXXDeleteExpr const * deleteExpr = nullptr;
    if (auto compoundStmt = dyn_cast<CompoundStmt>(cxxForRangeStmt->getBody()))
    {
        for (auto i = compoundStmt->body_begin(); i != compoundStmt->body_end(); ++i)
            if ((deleteExpr = dyn_cast<CXXDeleteExpr>(*i)))
                break;
    }
    else
        deleteExpr = dyn_cast<CXXDeleteExpr>(cxxForRangeStmt->getBody());
    if (!deleteExpr)
        return;

    // check for delete of member
    if (auto memberExpr = dyn_cast<MemberExpr>(cxxForRangeStmt->getRangeInit()))
    {
        auto fieldDecl = dyn_cast<FieldDecl>(memberExpr->getMemberDecl());
        if (!fieldDecl)
            return;

        // appears to just randomly leak stuff, and it involves some lex/yacc stuff
        if (fn == SRCDIR "/idlc/source/aststack.cxx")<--- first condition
            return;
        // complicated
        if (fn == SRCDIR "/vcl/source/gdi/print.cxx")<--- second condition<--- first condition
            return;
        // sometimes it's an owning field, sometimes not
        if (fn == SRCDIR "/i18npool/source/localedata/localedata.cxx")<--- second condition
            return;

        CheckMemberDeleteExpr(functionDecl, deleteExpr, memberExpr, "rather manage this with std::some_container<std::unique_ptr<T>>");
    }

    // check for delete of var
    if (auto declRefExpr = dyn_cast<DeclRefExpr>(cxxForRangeStmt->getRangeInit()->IgnoreParens()->IgnoreImplicit()))
    {
        auto varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl());
        if (!varDecl)
            return;

        // don't feel like messing with this part of sfx2
        if (fn == SRCDIR "/sfx2/source/control/msgpool.cxx")<--- first condition
            return;
        if (fn == SRCDIR "/sfx2/source/doc/doctemplates.cxx")<--- second condition<--- first condition
            return;
        // lex/yacc
        if (fn == SRCDIR "/hwpfilter/source/grammar.cxx")<--- second condition<--- first condition
            return;
        if (fn == SRCDIR "/hwpfilter/source/formula.cxx")<--- second condition<--- first condition
            return;
        // no idea why, but ui tests crash afterwards in weird ways
        if (fn == SRCDIR "/svtools/source/control/roadmap.cxx")<--- second condition<--- first condition
            return;
        // sometimes it owns it, sometimes it does not
        if (fn == SRCDIR "/dbaccess/source/ui/misc/WCopyTable.cxx")<--- second condition<--- first condition
            return;
        // SfxPoolItem array
        if (fn == SRCDIR "/dbaccess/source/ui/misc/UITools.cxx")<--- second condition<--- first condition
            return;
        // SfxPoolItem array
        if (fn == SRCDIR "/sw/source/core/bastyp/init.cxx")<--- second condition<--- first condition
            return;
        // SfxPoolItem array
        if (fn == SRCDIR "/reportdesign/source/ui/misc/UITools.cxx")<--- second condition<--- first condition
            return;
        // SfxPoolItem array
        if (fn == SRCDIR "/reportdesign/source/ui/report/ReportController.cxx")<--- second condition<--- first condition
            return;
        // complicated
        if (fn == SRCDIR "/svx/source/sdr/contact/viewcontact.cxx")<--- second condition<--- first condition
            return;
        if (fn == SRCDIR "/svx/source/sdr/contact/objectcontact.cxx")<--- second condition
            return;

        report(
            DiagnosticsEngine::Warning,
            "rather manage this var with std::some_container<std::unique_ptr<T>>",
            compat::getBeginLoc(deleteExpr))
            << deleteExpr->getSourceRange();
        report(
            DiagnosticsEngine::Note,
            "var is here",
            compat::getBeginLoc(varDecl))
            << varDecl->getSourceRange();
    }
}

void UseUniquePtr::CheckMemberDeleteExpr(const FunctionDecl* functionDecl, const CXXDeleteExpr* deleteExpr,
    const MemberExpr* memberExpr, StringRef message)
{
    // ignore union games
    const FieldDecl* fieldDecl = dyn_cast<FieldDecl>(memberExpr->getMemberDecl());
    if (!fieldDecl)
        return;
    TagDecl const * td = dyn_cast<TagDecl>(fieldDecl->getDeclContext());
    if (td->isUnion())
        return;

    // ignore calling delete on someone else's field
    if (auto methodDecl = dyn_cast<CXXMethodDecl>(functionDecl))
        if (fieldDecl->getParent() != methodDecl->getParent() )
            return;

    if (ignoreLocation(fieldDecl))
        return;
    // to ignore things like the CPPUNIT macros
    if (loplugin::hasPathnamePrefix(fn, WORKDIR "/"))
        return;
    // passes and stores pointers to member fields
    if (fn == SRCDIR "/sot/source/sdstor/stgdir.hxx")<--- first condition
        return;
    // something platform-specific
    if (fn == SRCDIR "/hwpfilter/source/htags.h")<--- second condition<--- first condition
        return;
    // passes pointers to member fields
    if (fn == SRCDIR "/sd/inc/sdpptwrp.hxx")<--- second condition<--- first condition
        return;
    // @TODO intrusive linked-lists here, with some trickiness
    if (fn == SRCDIR "/sw/source/filter/html/parcss1.hxx")<--- second condition<--- first condition
        return;
    // @TODO SwDoc has some weird ref-counting going on
    if (fn == SRCDIR "/sw/inc/shellio.hxx")<--- second condition<--- first condition
        return;
    // @TODO it's sharing pointers with another class
    if (fn == SRCDIR "/sc/inc/formulacell.hxx")<--- second condition
        return;
    // some weird stuff going on here around struct Entity
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/sax/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/include/sax/"))
        return;
    // manipulation of tree structures ie. StgAvlNode, don't lend themselves to std::unique_ptr
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/sot/"))
        return;
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/include/sot/"))
        return;
    // the std::vector is being passed to another class
    if (fn == SRCDIR "/sfx2/source/explorer/nochaos.cxx")
        return;
    auto tc = loplugin::TypeCheck(fieldDecl->getType());
    // these sw::Ring based classes do not lend themselves to std::unique_ptr management
    if (tc.Pointer().Class("SwNodeIndex").GlobalNamespace() || tc.Pointer().Class("SwShellTableCursor").GlobalNamespace()
        || tc.Pointer().Class("SwBlockCursor").GlobalNamespace() || tc.Pointer().Class("SwVisibleCursor").GlobalNamespace()
        || tc.Pointer().Class("SwShellCursor").GlobalNamespace())
        return;
    // there is a loop in ~ImplPrnQueueList deleting stuff on a global data structure
    if (fn == SRCDIR "/vcl/inc/print.h")<--- first condition
        return;
    // painful linked list
    if (fn == SRCDIR "/basic/source/inc/runtime.hxx")<--- second condition<--- first condition
        return;
    // not sure how the node management is working here
    if (fn == SRCDIR "/i18npool/source/localedata/saxparser.cxx")<--- second condition<--- first condition
        return;
    // has a pointer that it only sometimes owns
    if (fn == SRCDIR "/editeng/source/editeng/impedit.hxx")<--- second condition
        return;

    report(
        DiagnosticsEngine::Warning,
        message,
        compat::getBeginLoc(deleteExpr))
        << deleteExpr->getSourceRange();
    report(
        DiagnosticsEngine::Note,
        "member is here",
        compat::getBeginLoc(fieldDecl))
        << fieldDecl->getSourceRange();
}

bool UseUniquePtr::TraverseFunctionDecl(FunctionDecl* functionDecl)
{
    if (ignoreLocation(functionDecl))
        return true;

    auto oldCurrent = mpCurrentFunctionDecl;
    mpCurrentFunctionDecl = functionDecl;
    bool ret = RecursiveASTVisitor::TraverseFunctionDecl(functionDecl);
    mpCurrentFunctionDecl = oldCurrent;

    return ret;
}

bool UseUniquePtr::TraverseCXXMethodDecl(CXXMethodDecl* methodDecl)
{
    if (ignoreLocation(methodDecl))
        return true;

    auto oldCurrent = mpCurrentFunctionDecl;
    mpCurrentFunctionDecl = methodDecl;
    bool ret = RecursiveASTVisitor::TraverseCXXMethodDecl(methodDecl);
    mpCurrentFunctionDecl = oldCurrent;

    return ret;
}

bool UseUniquePtr::TraverseCXXDeductionGuideDecl(CXXDeductionGuideDecl* methodDecl)
{
    if (ignoreLocation(methodDecl))
        return true;

    auto oldCurrent = mpCurrentFunctionDecl;
    mpCurrentFunctionDecl = methodDecl;
    bool ret = RecursiveASTVisitor::TraverseCXXDeductionGuideDecl(methodDecl);
    mpCurrentFunctionDecl = oldCurrent;

    return ret;
}

bool UseUniquePtr::TraverseCXXConstructorDecl(CXXConstructorDecl* methodDecl)
{
    if (ignoreLocation(methodDecl))
        return true;

    auto oldCurrent = mpCurrentFunctionDecl;
    mpCurrentFunctionDecl = methodDecl;
    bool ret = RecursiveASTVisitor::TraverseCXXConstructorDecl(methodDecl);
    mpCurrentFunctionDecl = oldCurrent;

    return ret;
}

bool UseUniquePtr::TraverseCXXConversionDecl(CXXConversionDecl* methodDecl)
{
    if (ignoreLocation(methodDecl))
        return true;

    auto oldCurrent = mpCurrentFunctionDecl;
    mpCurrentFunctionDecl = methodDecl;
    bool ret = RecursiveASTVisitor::TraverseCXXConversionDecl(methodDecl);
    mpCurrentFunctionDecl = oldCurrent;

    return ret;
}

bool UseUniquePtr::TraverseCXXDestructorDecl(CXXDestructorDecl* methodDecl)
{
    if (ignoreLocation(methodDecl))
        return true;

    auto oldCurrent = mpCurrentFunctionDecl;
    mpCurrentFunctionDecl = methodDecl;
    bool ret = RecursiveASTVisitor::TraverseCXXDestructorDecl(methodDecl);
    mpCurrentFunctionDecl = oldCurrent;

    return ret;
}

bool UseUniquePtr::TraverseConstructorInitializer(CXXCtorInitializer * ctorInit)
{
    if (!ctorInit->getSourceLocation().isValid() || ignoreLocation(ctorInit->getSourceLocation()))
        return true;
    if (!ctorInit->getMember())
        return true;
    if (!loplugin::TypeCheck(ctorInit->getMember()->getType()).Class("unique_ptr").StdNamespace())
        return true;
    auto constructExpr = dyn_cast_or_null<CXXConstructExpr>(ctorInit->getInit());
    if (!constructExpr || constructExpr->getNumArgs() == 0)
        return true;
    auto init = constructExpr->getArg(0)->IgnoreImpCasts();
    if (!isa<DeclRefExpr>(init))
        return true;

    StringRef fn = getFileNameOfSpellingLoc(compiler.getSourceManager().getSpellingLoc(ctorInit->getSourceLocation()));
    // don't feel like fiddling with the yacc parser
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/idlc/"))
        return true;
    // cannot change URE
    if (loplugin::hasPathnamePrefix(fn, SRCDIR "/cppu/source/helper/purpenv/helper_purpenv_Environment.cxx"))
        return true;

    report(
        DiagnosticsEngine::Warning,
        "should be passing via std::unique_ptr param",
        ctorInit->getSourceLocation())
        << ctorInit->getSourceRange();
    return RecursiveASTVisitor<UseUniquePtr>::TraverseConstructorInitializer(ctorInit);
}

// Only checks for calls to delete on a pointer param
bool UseUniquePtr::VisitCXXDeleteExpr(const CXXDeleteExpr* deleteExpr)
{
    if (!mpCurrentFunctionDecl)
        return true;
    if (ignoreLocation(mpCurrentFunctionDecl))
        return true;
    if (isInUnoIncludeFile(compat::getBeginLoc(mpCurrentFunctionDecl->getCanonicalDecl())))
        return true;
    auto declRefExpr = dyn_cast<DeclRefExpr>(deleteExpr->getArgument()->IgnoreParenImpCasts()->IgnoreImplicit());
    if (!declRefExpr)
        return true;
    if (auto parmVarDecl = dyn_cast<ParmVarDecl>(declRefExpr->getDecl()))
        CheckDeleteParmVar(deleteExpr, parmVarDecl);
    else if (auto varDecl = dyn_cast<VarDecl>(declRefExpr->getDecl()))
        CheckDeleteLocalVar(mpCurrentFunctionDecl, deleteExpr, varDecl);
    return true;
}

void UseUniquePtr::CheckDeleteParmVar(const CXXDeleteExpr* deleteExpr, const ParmVarDecl* )
{
    if (mpCurrentFunctionDecl->getIdentifier())
    {
        auto name = mpCurrentFunctionDecl->getName();
        if (name == "delete_IncludesCollection" || name == "convertName"
            || name == "createNamedType"
            || name == "typelib_typedescriptionreference_release" || name == "deleteExceptions"
            || name == "uno_threadpool_destroy"
            || name == "AddRanges_Impl"
            || name == "DestroySalInstance"
            || name == "ImplHandleUserEvent"
            || name == "releaseDecimalPtr" // TODO, basic
            || name == "replaceAndReset" // TODO, connectivity
            || name == "intrusive_ptr_release"
            || name == "FreeParaList"
            || name == "DeleteSdrUndoAction" // TODO, sc
            || name == "lcl_MergeGCBox" || name == "lcl_MergeGCLine" || name == "lcl_DelHFFormat")
            return;
    }
    if (auto cxxMethodDecl = dyn_cast<CXXMethodDecl>(mpCurrentFunctionDecl))
    {
        auto parentName = cxxMethodDecl->getParent()->getName();
        // include/o3tl/deleter.hxx
        if (parentName == "default_delete")
            return;
        // TODO Bitmap::ReleaseAccess
        // Tricky because it reverberates through other code and requires that BitmapWriteAccess move into /include again
        if (parentName == "Bitmap")
            return;
        // TODO virtual ones are much trickier, leave for later
        if (cxxMethodDecl->isVirtual())
            return;
        // sw/inc/unobaseclass.hxx holds SolarMutex while deleting
        if (parentName == "UnoImplPtrDeleter")
            return;
    }

    // StgAvlNode::Remove
    if (fn == SRCDIR "/sot/source/sdstor/stgavl.cxx")<--- first condition
        return;
    // SfxItemPool::ReleaseDefaults and SfxItemPool::Free
    if (fn == SRCDIR "/svl/source/items/itempool.cxx")<--- second condition<--- first condition
        return;
    // SwContourCache
    if (fn == SRCDIR "/sw/source/core/text/txtfly.cxx")<--- second condition<--- first condition
        return;
    // too messy to cope with the SQL parser
    if (fn == SRCDIR "/connectivity/source/parse/sqlnode.cxx")<--- second condition<--- first condition
        return;
    // I can't figure out the ownership of the SfxMedium in the call site(s)
    if (fn == SRCDIR "/sfx2/source/doc/sfxbasemodel.cxx")<--- second condition<--- first condition
        return;
    // pointer passed via IMPL_LINK
    if (fn == SRCDIR "/sfx2/source/control/dispatch.cxx")<--- second condition<--- first condition
        return;
    // NavigatorTreeModel::Remove
    if (fn == SRCDIR "/svx/source/form/navigatortreemodel.cxx")<--- second condition<--- first condition
        return;
    // SdrModel::AddUndo
    if (fn == SRCDIR "/svx/source/svdraw/svdmodel.cxx")<--- second condition<--- first condition
        return;
    // undo callback
    if (fn == SRCDIR "/basctl/source/basicide/baside3.cxx")<--- second condition<--- first condition
        return;
    // ActualizeProgress::TimeoutHdl
    if (fn == SRCDIR "/cui/source/dialogs/cuigaldlg.cxx")<--- second condition<--- first condition
        return;
    // ToolbarSaveInData::RemoveToolbar
    if (fn == SRCDIR "/cui/source/customize/cfg.cxx")<--- second condition<--- first condition
        return;
    // OStorage_Impl::RemoveElement very complicated ownership passing going on
    if (fn == SRCDIR "/package/source/xstor/xstorage.cxx")<--- second condition<--- first condition
        return;
    // actually held via shared_ptr, uses protected deleter object
    if (fn == SRCDIR "/sd/source/ui/framework/tools/FrameworkHelper.cxx")<--- second condition<--- first condition
        return;
    // actually held via shared_ptr, uses protected deleter object
    if (fn == SRCDIR "/sd/source/ui/presenter/CanvasUpdateRequester.cxx")<--- second condition<--- first condition
        return;
    // actually held via shared_ptr, uses protected deleter object
    if (fn == SRCDIR "/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx")<--- second condition<--- first condition
        return;
    // actually held via shared_ptr, uses protected deleter object
    if (fn == SRCDIR "/sd/source/ui/sidebar/MasterPageContainer.cxx")<--- second condition<--- first condition
        return;
    // actually held via shared_ptr, uses protected deleter object
    if (fn == SRCDIR "/sd/source/ui/tools/TimerBasedTaskExecution.cxx")<--- second condition<--- first condition
        return;
    // actually held via shared_ptr, uses protected deleter object
    if (fn == SRCDIR "/sd/source/ui/view/ViewShellImplementation.cxx")<--- second condition<--- first condition
        return;
    // ScBroadcastAreaSlot::StartListeningArea manual ref-counting of ScBroadcastArea
    if (fn == SRCDIR "/sc/source/core/data/bcaslot.cxx")<--- second condition<--- first condition
        return;
    // ScDrawLayer::AddCalcUndo undo stuff
    if (fn == SRCDIR "/sc/source/core/data/drwlayer.cxx")<--- second condition<--- first condition
        return;
    // ScTable::SetFormulaCell
    if (fn == SRCDIR "/sc/source/core/data/table2.cxx")<--- second condition<--- first condition
        return;
    // ScDocument::SetFormulaCell
    if (fn == SRCDIR "/sc/source/core/data/documen2.cxx")<--- second condition<--- first condition
        return;
    // RemoveEditAttribsHandler, stored in mdds block
    if (fn == SRCDIR "/sc/source/core/data/column2.cxx")<--- second condition<--- first condition
        return;
    // just turns into a mess
    if (fn == SRCDIR "/sc/source/ui/Accessibility/AccessibleDocument.cxx")<--- second condition<--- first condition
        return;
    // SwCache::DeleteObj, linked list
    if (fn == SRCDIR "/sw/source/core/bastyp/swcache.cxx")<--- second condition<--- first condition
        return;
    // SAXEventKeeperImpl::smashBufferNode
    if (fn == SRCDIR "/xmlsecurity/source/framework/saxeventkeeperimpl.cxx")<--- second condition<--- first condition
        return;
    // SwDoc::DeleteExtTextInput
    if (fn == SRCDIR "/sw/source/core/doc/extinput.cxx")<--- second condition<--- first condition
        return;
    // SwDoc::DelSectionFormat
    if (fn == SRCDIR "/sw/source/core/docnode/ndsect.cxx")<--- second condition<--- first condition
        return;
    // SwFrame::DestroyFrame
    if (fn == SRCDIR "/sw/source/core/layout/ssfrm.cxx")<--- second condition<--- first condition
        return;
    // SwGluePortion::Join
    if (fn == SRCDIR "/sw/source/core/text/porglue.cxx")<--- second condition<--- first condition
        return;
    // SwDoc::DelFrameFormat
    if (fn == SRCDIR "/sw/source/core/doc/docfmt.cxx")<--- second condition<--- first condition
        return;
    // SwTextAttr::Destroy
    if (fn == SRCDIR "/sw/source/core/txtnode/txatbase.cxx")<--- second condition<--- first condition
        return;
    // IMPL_LINK( SwDoc, AddDrawUndo, SdrUndoAction *, pUndo, void )
    if (fn == SRCDIR "/sw/source/core/undo/undraw.cxx")<--- second condition<--- first condition
        return;
    // SwHTMLParser::EndAttr
    if (fn == SRCDIR "/sw/source/filter/html/swhtml.cxx")<--- second condition<--- first condition
        return;
    // SwGlossaryHdl::Expand sometimes the pointer is owned, sometimes it is not
    if (fn == SRCDIR "/sw/source/uibase/dochdl/gloshdl.cxx")<--- second condition<--- first condition
        return;
    // SwWrtShell::Insert only owned sometimes
    if (fn == SRCDIR "/sw/source/uibase/wrtsh/wrtsh1.cxx")<--- second condition<--- first condition
        return;
    // NodeArrayDeleter
    if (fn == SRCDIR "/unoxml/source/rdf/librdf_repository.cxx")<--- second condition<--- first condition
        return;
    // SmCursor::LineToList ran out of enthusiasm to rework the node handling
    if (fn == SRCDIR "/starmath/source/cursor.cxx")<--- second condition<--- first condition
        return;
    // XMLEventOASISTransformerContext::FlushEventMap
    if (fn == SRCDIR "/xmloff/source/transform/EventOASISTContext.cxx")<--- second condition<--- first condition
        return;
    // XMLEventOOoTransformerContext::FlushEventMap
    if (fn == SRCDIR "/xmloff/source/transform/EventOOoTContext.cxx")<--- second condition<--- first condition
        return;
    // SbiProcDef::Match
    if (fn == SRCDIR "/basic/source/comp/symtbl.cxx")<--- second condition
        return;

    /*
    Sometimes we can pass the param as std::unique_ptr<T>& or std::unique_ptr, sometimes the method
    just needs to be inlined, which normally exposes more simplification.
    */
    report(
        DiagnosticsEngine::Warning,
        "calling delete on a pointer param, should be either whitelisted or simplified",
        compat::getBeginLoc(deleteExpr))
        << deleteExpr->getSourceRange();
}


loplugin::Plugin::Registration< UseUniquePtr > X("useuniqueptr", false);

}

/* vim:set shiftwidth=4 softtabstop=4 expandtab: */