Cppcheck report - LibreOffice 2020-06-13 19:58:00 41c465b5ee443ec04441077b5eb80f263336ea8a, CppCheck 2020-06-13 18:19:47 6d5d12f283cf568d2dfe09aa77cb41f34b322d62: compilerplugins/clang/test/stringadd.cxx

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
 * This file is part of the LibreOffice project.
 *
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 */

#include <rtl/strbuf.hxx>
#include <rtl/string.hxx>
#include <rtl/ustrbuf.hxx>
#include <rtl/ustring.hxx>

// ---------------------------------------------------------------
// += tests

namespace test1
{
static const char XXX1[] = "xxx";
static const char XXX2[] = "xxx";
void f1(OUString s1, int i, OString o)
{
    OUString s2 = s1;
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += "xxx";
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += "xxx";
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += s1;<--- s2 is assigned
    s2 = s1 + "xxx";<--- s2 is overwritten<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += s1;<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += OUString::number(i);<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += XXX1;<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += OUStringLiteral(XXX1) + XXX2;<--- Variable 's2' is assigned a value that is never used.

    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += OStringToOUString(o, RTL_TEXTENCODING_UTF8);<--- Variable 's2' is assigned a value that is never used.
}
void f2(OString s1, int i, OUString u)
{
    OString s2 = s1;
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += "xxx";
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += "xxx";
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += s1;<--- s2 is assigned
    s2 = s1 + "xxx";<--- s2 is overwritten<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += s1;<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += OString::number(i);<--- Variable 's2' is assigned a value that is never used.

    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += OUStringToOString(u, RTL_TEXTENCODING_ASCII_US);<--- Variable 's2' is assigned a value that is never used.
}
void f3(OUString aStr, int nFirstContent)
{
    OUString aFirstStr = aStr.copy(0, nFirstContent);<--- Variable 'aFirstStr' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    aFirstStr += "...";<--- Variable 'aFirstStr' is assigned a value that is never used.
}
OUString side_effect();
void f4(int i)
{
    OUString s1;
    OUString s2("xxx");
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += "xxx";<--- Variable 's2' is assigned a value that is never used.
    ++i;<--- Assignment of function parameter has no effect outside the function.<--- Variable 'i' is assigned a value that is never used.
    // any other kind of statement breaks the chain (at least for now)
    s2 += "xxx";<--- Variable 's2' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s2 += side_effect();<--- Variable 's2' is assigned a value that is never used.
    s1 += "yyy";<--- Variable 's1' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s1 += "yyy";<--- Variable 's1' is assigned a value that is never used.
}
}

namespace test2
{
void f(OUString s3)
{
    s3 += "xxx";<--- Variable 's3' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s3 += "xxx";<--- Variable 's3' is assigned a value that is never used.
}
void g(OString s3)
{
    s3 += "xxx";<--- Variable 's3' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s3 += "xxx";<--- Variable 's3' is assigned a value that is never used.
}
}

namespace test3
{
struct Bar
{
    OUString m_field;
};
void f(Bar b1, Bar& b2, Bar* b3)<--- Parameter 'b2' can be declared with const
{
    OUString s3 = "xxx";<--- Variable 's3' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s3 += b1.m_field;<--- Variable 's3' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s3 += b2.m_field;<--- Variable 's3' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    s3 += b3->m_field;<--- Variable 's3' is assigned a value that is never used.
}
OUString side_effect();
void f2(OUString s)
{
    OUString sRet = "xxx";<--- Variable 'sRet' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sRet += side_effect();<--- Variable 'sRet' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sRet += "xxx";<--- Variable 'sRet' is assigned a value that is never used.
    sRet += side_effect();<--- Variable 'sRet' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sRet += "xxx";<--- Variable 'sRet' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sRet += "xxx";<--- Variable 'sRet' is assigned a value that is never used.
    sRet += s;<--- Variable 'sRet' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sRet += "xxx";<--- Variable 'sRet' is assigned a value that is never used.
}
}

// no warning expected
namespace test4
{
OUString side_effect();
void f()
{
    OUString sRet = "xxx";<--- Variable 'sRet' is assigned a value that is never used.
#if OSL_DEBUG_LEVEL > 0
    sRet += ";";
#endif
    sRet += " ";<--- Variable 'sRet' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sRet += side_effect();<--- Variable 'sRet' is assigned a value that is never used.
}
}

// no warning expected
namespace test5
{
OUString side_effect();
void f()
{
    OUString sRet = side_effect();<--- Variable 'sRet' is assigned a value that is never used.
    sRet += side_effect();<--- Variable 'sRet' is assigned a value that is never used.
}
}

namespace test6
{
void f(OUString sComma, OUString maExtension, int mnDocumentIconID)
{
    OUString sValue;
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sValue += sComma + sComma + maExtension + sComma;<--- Variable 'sValue' is assigned a value that is never used.
    // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
    sValue += OUString::number(mnDocumentIconID) + sComma;<--- Variable 'sValue' is assigned a value that is never used.
}
struct Foo
{
    OUString sFormula1;
};
void g(int x, const Foo& aValidation)
{
    OUString sCondition;
    switch (x)
    {
        case 1:
            sCondition += "cell-content-is-in-list(";<--- Variable 'sCondition' is assigned a value that is never used.
            // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}}
            sCondition += aValidation.sFormula1 + ")";<--- Variable 'sCondition' is assigned a value that is never used.
    }
}
}

// ---------------------------------------------------------------
// detecting OUString temporary construction in +

namespace test9
{
OUString getByValue();
const OUString& getByRef();
void f1(OUString s, OUString t, int i, const char* pChar)
{
    // no warning expected
    t = t + "xxx";<--- Variable 't' is assigned a value that is never used.
    // expected-error@+1 {{avoid constructing 'rtl::OUString' from 'const char [4]' on RHS of + (where LHS is of type 'rtl::OUString') [loplugin:stringadd]}}
    s = s + OUString("xxx");
    // expected-error@+1 {{avoid constructing 'rtl::OUString' from 'const rtl::OUString' on RHS of + (where LHS is of type 'rtl::OUString') [loplugin:stringadd]}}
    s = s + OUString(getByRef());<--- Variable 's' is assigned a value that is never used.

    // no warning expected
    OUString a;
    a = a + getByValue();<--- Variable 'a' is assigned a value that is never used.

    // no warning expected
    OUString b;
    b = b + (i == 1 ? "aaa" : "bbb");<--- Variable 'b' is assigned a value that is never used.

    // no warning expected
    OUString c;
    c = c + OUString(pChar, strlen(pChar), RTL_TEXTENCODING_UTF8);<--- Variable 'c' is assigned a value that is never used.
}
void f2(char ch)
{
    OString s;
    // expected-error@+1 {{avoid constructing 'rtl::OString' from 'const char [4]' on RHS of + (where LHS is of type 'rtl::OString') [loplugin:stringadd]}}
    s = s + OString("xxx");
    // expected-error@+1 {{avoid constructing 'rtl::OString' from 'char' on RHS of + (where LHS is of type 'rtl::OString') [loplugin:stringadd]}}
    s = s + OString(ch);<--- Variable 's' is assigned a value that is never used.
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */