1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210 | /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <fbcreateparser.hxx>
#include <columndef.hxx>
#include <cppunit/plugin/TestPlugIn.h>
#include <com/sun/star/sdbc/DataType.hpp>
#include <cppunit/TestFixture.h>
#include <cppunit/extensions/HelperMacros.h>
using namespace dbahsql;
namespace
{
constexpr std::size_t operator"" _z(unsigned long long n) { return n; }
const ColumnDefinition* lcl_findByType(const std::vector<ColumnDefinition>& columns,
sal_Int32 nType)
{
for (const auto& column : columns)
{
if (column.getDataType() == nType)<--- Consider using std::find_if algorithm instead of a raw loop.
return &column;
}
return nullptr;
}
}
class HsqlSchemaImportTest : public CppUnit::TestFixture
{
public:
void testIntegerPrimaryKeyNotNull();
void testVarcharWithParam();
void testVarcharWithoutParam();
void testNumericWithTwoParam();
void testIntegerAutoincremental();
void testTimestampWithParam();
void testDefaultValueNow();
void testEvilNullColumnName();
// TODO testForeign, testDecomposer
CPPUNIT_TEST_SUITE(HsqlSchemaImportTest);
CPPUNIT_TEST(testIntegerPrimaryKeyNotNull);
CPPUNIT_TEST(testVarcharWithParam);
CPPUNIT_TEST(testVarcharWithoutParam);
CPPUNIT_TEST(testNumericWithTwoParam);
CPPUNIT_TEST(testIntegerAutoincremental);
CPPUNIT_TEST(testTimestampWithParam);
CPPUNIT_TEST(testDefaultValueNow);
CPPUNIT_TEST(testEvilNullColumnName);
CPPUNIT_TEST_SUITE_END();
};
void HsqlSchemaImportTest::testIntegerPrimaryKeyNotNull()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse("CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY)");
CPPUNIT_ASSERT_EQUAL(OUString{ "\"myTable\"" }, aCreateParser.getTableName());
const auto& columns = aCreateParser.getColumnDef();
CPPUNIT_ASSERT_EQUAL(1_z, columns.size());
const auto& column = columns.at(0);
CPPUNIT_ASSERT_EQUAL(OUString{ "\"id\"" }, column.getName());
CPPUNIT_ASSERT_EQUAL(css::sdbc::DataType::INTEGER, column.getDataType());
CPPUNIT_ASSERT(column.isPrimaryKey());
CPPUNIT_ASSERT(!column.isNullable());
CPPUNIT_ASSERT(!column.isAutoIncremental());
}
void HsqlSchemaImportTest::testVarcharWithParam()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse(
"CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY, \"myText\" "
"VARCHAR(50))");
const auto& columns = aCreateParser.getColumnDef();
CPPUNIT_ASSERT_EQUAL(2_z, columns.size());
const ColumnDefinition* colVarchar = lcl_findByType(columns, css::sdbc::DataType::VARCHAR);<--- Assignment 'colVarchar=lcl_findByType(columns,css::sdbc::DataType::VARCHAR)', assigned value is 0
CPPUNIT_ASSERT(colVarchar != nullptr);<--- Assuming that condition 'colVarchar!=nullptr' is not redundant
const auto& params = colVarchar->getParams();<--- Null pointer dereference
CPPUNIT_ASSERT_EQUAL(1_z, params.size());
constexpr sal_Int32 nParamExpected = 50;
CPPUNIT_ASSERT_EQUAL(nParamExpected, params.at(0)); // VARCHAR(50)
}
/**
* Special case:
* HSQLDB might define a column VARCHAR without parameter. With Firebird
* dialect, this is forbidden, so a default parameter has to be appended:
**/
void HsqlSchemaImportTest::testVarcharWithoutParam()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse(
"CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY, \"myText\" "
"VARCHAR)");
const auto& columns = aCreateParser.getColumnDef();
CPPUNIT_ASSERT_EQUAL(2_z, columns.size());
const ColumnDefinition* colVarchar = lcl_findByType(columns, css::sdbc::DataType::VARCHAR);<--- Assignment 'colVarchar=lcl_findByType(columns,css::sdbc::DataType::VARCHAR)', assigned value is 0
CPPUNIT_ASSERT(colVarchar != nullptr);<--- Assuming that condition 'colVarchar!=nullptr' is not redundant
const auto& params = colVarchar->getParams();<--- Null pointer dereference
CPPUNIT_ASSERT_EQUAL(1_z, params.size()); // parameter generated
}
void HsqlSchemaImportTest::testNumericWithTwoParam()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse(
"CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY, \"Betrag\" "
"NUMERIC(8,2))");
const auto& columns = aCreateParser.getColumnDef();
CPPUNIT_ASSERT_EQUAL(2_z, columns.size());
const ColumnDefinition* colNumeric = lcl_findByType(columns, css::sdbc::DataType::NUMERIC);<--- Assignment 'colNumeric=lcl_findByType(columns,css::sdbc::DataType::NUMERIC)', assigned value is 0
CPPUNIT_ASSERT(colNumeric != nullptr);<--- Assuming that condition 'colNumeric!=nullptr' is not redundant
const auto& params = colNumeric->getParams();<--- Null pointer dereference
CPPUNIT_ASSERT_EQUAL(2_z, params.size());
constexpr sal_Int32 nPrecision = 8;
constexpr sal_Int32 nScale = 2;
CPPUNIT_ASSERT_EQUAL(nPrecision, params.at(0));
CPPUNIT_ASSERT_EQUAL(nScale, params.at(1));
}
void HsqlSchemaImportTest::testIntegerAutoincremental()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse(
"CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY GENERATED "
"BY DEFAULT AS IDENTITY(START WITH 0), \"myText\" VARCHAR(50))");
const auto& columns = aCreateParser.getColumnDef();
const auto column = columns.at(0);
CPPUNIT_ASSERT_EQUAL(css::sdbc::DataType::INTEGER, column.getDataType());
CPPUNIT_ASSERT(column.isAutoIncremental());
CPPUNIT_ASSERT(column.isPrimaryKey());
CPPUNIT_ASSERT(!column.isNullable());
}
/**
* Special case:
* Hsqldb might use one parameter for defining column with type TIMESTAMP.
* With Firebird this is illegal.
*/
void HsqlSchemaImportTest::testTimestampWithParam()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse(
"CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY, \"myText\" "
"TIMESTAMP(0))");
const auto& columns = aCreateParser.getColumnDef();
const ColumnDefinition* colTimeStamp = lcl_findByType(columns, css::sdbc::DataType::TIMESTAMP);
CPPUNIT_ASSERT(colTimeStamp != nullptr);
// instead of asserting parameter size, look at the deparsed string,
// because it's Firebird specific
OUString fbSql = aCreateParser.compose();
CPPUNIT_ASSERT(fbSql.indexOf("0") < 0); //does not contain
}
/**
* Special case:
* HSQLDB uses keyword NOW without quotes. Firebird uses single quotes 'NOW'
*/
void HsqlSchemaImportTest::testDefaultValueNow()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse(
"CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY, \"myDate\" "
"TIMESTAMP DEFAULT NOW)");
const auto& columns = aCreateParser.getColumnDef();
const ColumnDefinition* colTimeStamp = lcl_findByType(columns, css::sdbc::DataType::TIMESTAMP);<--- Assignment 'colTimeStamp=lcl_findByType(columns,css::sdbc::DataType::TIMESTAMP)', assigned value is 0
CPPUNIT_ASSERT(colTimeStamp != nullptr);<--- Assuming that condition 'colTimeStamp!=nullptr' is not redundant
CPPUNIT_ASSERT_EQUAL(OUString{ "NOW" }, colTimeStamp->getDefault()); // parsed NOW<--- Null pointer dereference
OUString fbSql = aCreateParser.compose();
CPPUNIT_ASSERT(fbSql.indexOf("\'NOW\'") > 0); // composed 'NOW'
}
void HsqlSchemaImportTest::testEvilNullColumnName()
{
FbCreateStmtParser aCreateParser;
aCreateParser.parse("CREATE CACHED TABLE \"myTable\"(\"id\" INTEGER NOT NULL PRIMARY KEY, "
"\"myEvilNOT NULLName\" "
"VARCHAR(20))");
const auto& columns = aCreateParser.getColumnDef();
CPPUNIT_ASSERT_EQUAL(2_z, columns.size());
const ColumnDefinition* colVarchar = lcl_findByType(columns, css::sdbc::DataType::VARCHAR);<--- Assignment 'colVarchar=lcl_findByType(columns,css::sdbc::DataType::VARCHAR)', assigned value is 0
CPPUNIT_ASSERT(colVarchar != nullptr);<--- Assuming that condition 'colVarchar!=nullptr' is not redundant
CPPUNIT_ASSERT(colVarchar->isNullable());<--- Null pointer dereference
}
CPPUNIT_TEST_SUITE_REGISTRATION(HsqlSchemaImportTest);
CPPUNIT_PLUGIN_IMPLEMENT();
|