1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218 | /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <sal/config.h>
#include <o3tl/safeint.hxx>
#include "bundles.hxx"
#include "cgm.hxx"
#include "elements.hxx"
void CGM::ImplDoClass1()
{
long nInteger, nI0, nI1;<--- The scope of the variable 'nI0' can be reduced. [+]The scope of the variable 'nI0' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
sal_uInt32 nUInteger;
switch ( mnElementID )
{
case 0x01 : /*Metafile Version*/
pElement->nMetaFileVersion = ImplGetI( pElement->nIntegerPrecision );
break;
case 0x02 : /*Metafile Description */break;
case 0x03 : /*VDC Type*/
{
nUInteger = ImplGetUI16();
switch( nUInteger )
{
case 0 : pElement->eVDCType = VDC_INTEGER; break;
case 1 : pElement->eVDCType = VDC_REAL; break;
default: mbStatus = false; break;
}
}
break;
case 0x04 : /*Integer Precision*/
{
nInteger = ImplGetI( pElement->nIntegerPrecision );
switch ( nInteger )
{
case 32 :
case 24 :
case 16 :
case 8 : pElement->nIntegerPrecision = nInteger >> 3; break;
default : mbStatus = false; break;
}
}
break;
case 0x05 : /*Real Precision*/
{
nUInteger = ImplGetUI16();
nI0 = ImplGetI( pElement->nIntegerPrecision ); // exponent
nI1 = ImplGetI( pElement->nIntegerPrecision ); // mantissa
switch( nUInteger )
{
case 0 :
pElement->eRealPrecision = RP_FLOAT;
switch ( nI0 )
{
case 9 :
if ( nI1 != 23 )
mbStatus = false;
pElement->nRealSize = 4;
break;
case 12 :
if ( nI1 != 52 )
mbStatus =false;
pElement->nRealSize = 8;
break;
default:
mbStatus = false;
break;
}
break;
case 1 :
pElement->eRealPrecision = RP_FIXED;
if ( nI0 != nI1 )
mbStatus = false;
if ( nI0 == 16 )
pElement->nRealSize = 4;
else if ( nI0 == 32 )
pElement->nRealSize = 8;
else
mbStatus = false;
break;
default :
mbStatus = false; break;
}
}
break;
case 0x06 : /*Index Precision*/
{
nInteger = ImplGetI( pElement->nIntegerPrecision );
switch ( nInteger )
{
case 32 :
case 24 :
case 16 :
case 8 : pElement->nIndexPrecision = nInteger >> 3; break;
default : mbStatus = false; break;
}
}
break;
case 0x07 : /*Color Precision*/
{
nInteger = ImplGetI( pElement->nIntegerPrecision );
switch ( nInteger )
{
case 32 :
case 24 :
case 16 :
case 8 : pElement->nColorPrecision = nInteger >> 3; break;
default : mbStatus = false; break;
}
}
break;
case 0x08 : /*Color Index Precision*/
{
nInteger = ImplGetI( pElement->nIntegerPrecision );
switch ( nInteger )
{
case 32 :
case 24 :
case 16 :
case 8 : pElement->nColorIndexPrecision = nInteger >> 3; break;
default : mbStatus = false; break;
}
}
break;
case 0x09 : /*Maximum Colour Index*/
{
pElement->nColorMaximumIndex = ImplGetUI( pElement->nColorIndexPrecision );
if ( ( pElement->nColorMaximumIndex > 256 /*255*/ ) || ( pElement->nColorMaximumIndex == 0 ) )
mbStatus = false;
}
break;
case 0x0a : /*Color Value Extent*/
{
nI1 = 6;<--- Variable 'nI1' is assigned a value that is never used.
}
break;
case 0x0b : /*MetaFile Element List */break;
case 0x0c : /*MetaFile Default Replacement*/
{
if ( mnElementSize > 1 )
{
std::unique_ptr<sal_uInt8[]> pBuf(new sal_uInt8[ mnElementSize ]);
memcpy( pBuf.get(), mpSource, mnElementSize );
maDefRepList.push_back( std::move(pBuf) );
maDefRepSizeList.push_back( mnElementSize );
}
mnParaSize = mnElementSize;
}
break;
case 0x0d : /*Font List*/
{
while ( mnParaSize < mnElementSize )
{
sal_uInt32 nSize = ImplGetUI(1);
if (o3tl::make_unsigned(mpEndValidSource - (mpSource + mnParaSize)) < nSize)
throw css::uno::Exception("attempt to read past end of input", nullptr);
pElement->aFontList.InsertName( mpSource + mnParaSize, nSize );
mnParaSize += nSize;
}
}
break;
case 0x0e : /*Character Set List*/
{
while ( mnParaSize < mnElementSize )
{
ImplGetUI16(); // skip CharSetType
sal_uInt32 nSize = ImplGetUI(1);
if (o3tl::make_unsigned(mpEndValidSource - (mpSource + mnParaSize)) < nSize)
throw css::uno::Exception("attempt to read past end of input", nullptr);
pElement->aFontList.InsertCharSet( mpSource + mnParaSize, nSize );
mnParaSize += nSize;
}
}
break;
case 0x0f : /*Character Coding Announcer*/
pElement->eCharacterCodingA = static_cast<CharacterCodingA>(ImplGetUI16());
break;
case 0x10 : /*Name Precision */break; // NS
case 0x11 : /*Maximum VDC Extent */break; // NS
case 0x12 : /*Segment Priority Extent */break; // NS
case 0x13 : /*Color Model */break; // NS
case 0x14 : /*Color Calibration */break; // NS
case 0x15 : /*Font Properties */break; // NS
case 0x16 : /*Glyph Mapping */break; // NS
case 0x17 : /*Symbol Library List */break; // NS
case 0xfc : /*Inquire Function Support */break;
case 0xfa : /*End Metafile Defaults Replacement */break;
case 0xf8 : /*Set Color Value Desc Extent */break;
default: break;
}
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|